Deuxfleurs/garage
48
56
Fork 73
Code Issues 100 Pull requests 13 Releases 30 Wiki Activity

Payload on 400 error for HEAD requests #624

New issue
Closed
opened 2023-08-31 17:02:09 +00:00 by earl-warren · 6 comments
earl-warren commented 2023-08-31 17:02:09 +00:00
Copy link

When sending a HEAD /bucket/ request with an incorrect region, the 400 error returned by garage 0.8.2 setup with this script is empty.

The tcpdump output (in full below) has:

HTTP/1.1 400 Bad Request
content-type: application/xml
content-length: 252
date: Thu, 31 Aug 2023 16:56:26 GMT

Is this a misconfiguration of garage? It would be helpful to have more information to display to the Forgejo user when they set the wrong region: this is why there is a particular interest in the content of this error.

$ sudo tcpdump -A -s 0 -i lo port 9000 tcpdump: verbose output suppressed, use -v[v]... for full protocol decode listening on lo, link-type EN10MB (Ethernet), snapshot length 262144 bytes 18:56:26.595565 IP localhost.43304 > localhost.9000: Flags [S], seq 239110995, win 65495, options [mss 65495,sackOK,TS val 3833192476 ecr 0,nop,wscale 7], length 0 E..<..@.@............(#(.@.S.........0......... .y.......... 18:56:26.595579 IP localhost.9000 > localhost.43304: Flags [S.], seq 3278046014, ack 239110996, win 65483, options [mss 65495,sackOK,TS val 3833192476 ecr 3833192476,nop,wscale 7], length 0 E..<..@.@.<.........#(.(.c.>.@.T.....0......... .y...y...... 18:56:26.595588 IP localhost.43304 > localhost.9000: Flags [.], ack 1, win 512, options [nop,nop,TS val 3833192476 ecr 3833192476], length 0 E..4..@.@............(#(.@.T.c.?.....(..... .y...y.. 18:56:26.595683 IP localhost.43304 > localhost.9000: Flags [P.], seq 1:428, ack 1, win 512, options [nop,nop,TS val 3833192476 ecr 3833192476], length 427 E.....@.@............(#(.@.T.c.?........... .y...y..HEAD /bucket/ HTTP/1.1 Host: minio:9000 User-Agent: MinIO (linux; amd64) minio-go/v7.0.61 Authorization: AWS4-HMAC-SHA256 Credential=123456/20230831/badregion/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=a5c84e0c09d6c1edd623714d8e4e4f26c6676bcd0701cce3210927c568817e43 X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 X-Amz-Date: 20230831T165626Z

18:56:26.595691 IP localhost.9000 > localhost.43304: Flags [.], ack 428, win 509, options [nop,nop,TS val 3833192476 ecr 3833192476], length 0
E..4PS@.@..n........#(.(.c.?.@.......(.....
.y...y..
18:56:26.595855 IP localhost.9000 > localhost.43304: Flags [P.], seq 1:118, ack 428, win 512, options [nop,nop,TS val 3833192477 ecr 3833192476], length 117
E...PT@.@...........#(.(.c.?.@.............
.y...y..HTTP/1.1 400 Bad Request
content-type: application/xml
content-length: 252
date: Thu, 31 Aug 2023 16:56:26 GMT

18:56:26.595864 IP localhost.43304 > localhost.9000: Flags [.], ack 118, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0
E..4..@.@............(#(.@...c.......(.....
.y...y..
18:56:26.596495 IP localhost.43304 > localhost.9000: Flags [F.], seq 428, ack 118, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0
E..4..@.@............(#(.@...c.......(.....
.y...y..
18:56:26.596519 IP localhost.9000 > localhost.43304: Flags [F.], seq 118, ack 429, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0
E..4PU@.@..l........#(.(.c...@.......(.....
.y...y..
18:56:26.596530 IP localhost.43304 > localhost.9000: Flags [.], ack 119, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0
E..4..@.@............(#(.@...c.......(.....
.y...y..

When sending a `HEAD /bucket/` request with an incorrect region, the 400 error returned by [garage 0.8.2](https://codeberg.org/forgejo/forgejo/src/branch/forgejo-development/.forgejo/upgrades/test-upgrade.sh#L54) setup [with this script](https://codeberg.org/forgejo/forgejo/src/branch/forgejo-development/.forgejo/upgrades/test-upgrade.sh#L139-L182) is empty. The tcpdump output (in full below) has: ``` HTTP/1.1 400 Bad Request content-type: application/xml content-length: 252 date: Thu, 31 Aug 2023 16:56:26 GMT ``` Is this a misconfiguration of garage? It would be helpful to have more information to display to the Forgejo user when they set the wrong region: this is why there is a particular interest in the content of this error. <details> $ sudo tcpdump -A -s 0 -i lo port 9000 tcpdump: verbose output suppressed, use -v[v]... for full protocol decode listening on lo, link-type EN10MB (Ethernet), snapshot length 262144 bytes 18:56:26.595565 IP localhost.43304 > localhost.9000: Flags [S], seq 239110995, win 65495, options [mss 65495,sackOK,TS val 3833192476 ecr 0,nop,wscale 7], length 0 E..<..@.@............(#(.@.S.........0......... .y.......... 18:56:26.595579 IP localhost.9000 > localhost.43304: Flags [S.], seq 3278046014, ack 239110996, win 65483, options [mss 65495,sackOK,TS val 3833192476 ecr 3833192476,nop,wscale 7], length 0 E..<..@.@.<.........#(.(.c.>.@.T.....0......... .y...y...... 18:56:26.595588 IP localhost.43304 > localhost.9000: Flags [.], ack 1, win 512, options [nop,nop,TS val 3833192476 ecr 3833192476], length 0 E..4..@.@............(#(.@.T.c.?.....(..... .y...y.. 18:56:26.595683 IP localhost.43304 > localhost.9000: Flags [P.], seq 1:428, ack 1, win 512, options [nop,nop,TS val 3833192476 ecr 3833192476], length 427 E.....@.@............(#(.@.T.c.?........... .y...y..HEAD /bucket/ HTTP/1.1 Host: minio:9000 User-Agent: MinIO (linux; amd64) minio-go/v7.0.61 Authorization: AWS4-HMAC-SHA256 Credential=123456/20230831/badregion/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=a5c84e0c09d6c1edd623714d8e4e4f26c6676bcd0701cce3210927c568817e43 X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 X-Amz-Date: 20230831T165626Z 18:56:26.595691 IP localhost.9000 > localhost.43304: Flags [.], ack 428, win 509, options [nop,nop,TS val 3833192476 ecr 3833192476], length 0 E..4PS@.@..n........#(.(.c.?.@.......(..... .y...y.. 18:56:26.595855 IP localhost.9000 > localhost.43304: Flags [P.], seq 1:118, ack 428, win 512, options [nop,nop,TS val 3833192477 ecr 3833192476], length 117 E...PT@.@...........#(.(.c.?.@............. .y...y..HTTP/1.1 400 Bad Request content-type: application/xml content-length: 252 date: Thu, 31 Aug 2023 16:56:26 GMT 18:56:26.595864 IP localhost.43304 > localhost.9000: Flags [.], ack 118, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0 E..4..@.@............(#(.@...c.......(..... .y...y.. 18:56:26.596495 IP localhost.43304 > localhost.9000: Flags [F.], seq 428, ack 118, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0 E..4..@.@............(#(.@...c.......(..... .y...y.. 18:56:26.596519 IP localhost.9000 > localhost.43304: Flags [F.], seq 118, ack 429, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0 E..4PU@.@..l........#(.(.c...@.......(..... .y...y.. 18:56:26.596530 IP localhost.43304 > localhost.9000: Flags [.], ack 119, win 512, options [nop,nop,TS val 3833192477 ecr 3833192477], length 0 E..4..@.@............(#(.@...c.......(..... .y...y.. </details>
lx commented 2023-08-31 17:52:07 +00:00
Owner
Copy link

New discovery : an error response to a HEAD request is not supposed to have a body

I don't think we have specific code to not send the response body if the request is a HEAD, but I wouldn't be surprised if it is the hyper http library that removes it automatically to ensure protocol conformance.

This means that the region redirection mechanism cannot work with just a head request, unfortunately... I think it is implemented in the minio client, and maybe in the minio client library, could we look at how they do it?

New discovery : [an error response to a HEAD request is not supposed to have a body](https://developer.mozilla.org/en-US/docs/web/http/methods/head) I don't think we have specific code to not send the response body if the request is a HEAD, but I wouldn't be surprised if it is the hyper http library that removes it automatically to ensure protocol conformance. This means that the region redirection mechanism cannot work with just a head request, unfortunately... I think it is implemented in the minio client, and maybe in the minio client library, could we look at how they do it?
earl-warren commented 2023-08-31 19:31:53 +00:00
Author
Copy link

@gusted looked at it and found some information. I'll try using GET instead see where that gets me.

@gusted looked at it and [found some information](https://codeberg.org/forgejo/forgejo/issues/1344#issuecomment-1075551). I'll try using GET instead see where that gets me.
earl-warren commented 2023-08-31 19:43:33 +00:00
Author
Copy link

Using GET the 400 payload is present, you are correct: HEAD hides it somewhere in the codepath.

GET / HTTP/1.1
Host: minio:9000
User-Agent: MinIO (linux; amd64) minio-go/v7.0.61
Authorization: AWS4-HMAC-SHA256 Credential=123456/20230831/badregion/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=a0c9454bdfc0187f76c4c58ac881c9feea7a9d539c5d6b48b5a0d8fca0621f9b
X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20230831T194154Z
Accept-Encoding: gzip


21:41:54.333195 IP localhost.9000 > localhost.45112: Flags [.], ack 443, win 509, options [nop,nop,TS val 3843120214 ecr 3843120214], length 0
E..4IP@.@..q........#(.8g............(.....
..\V..\V
21:41:54.333380 IP localhost.9000 > localhost.45112: Flags [P.], seq 1:363, ack 443, win 512, options [nop,nop,TS val 3843120214 ecr 3843120214], length 362
E...IQ@.@...........#(.8g..................
..\V..\VHTTP/1.1 400 Bad Request
content-type: application/xml
content-length: 245
date: Thu, 31 Aug 2023 19:41:54 GMT

<?xml version="1.0" encoding="UTF-8"?><Error><Code>AuthorizationHeaderMalformed</Code><Message>Authorization header malformed, unexpected scope: 20230831/badregion/s3/aws4_request</Message><Resource>/</Resource><Region>us-east-1</Region></Error>
Using GET the 400 payload is present, you are correct: HEAD hides it somewhere in the codepath. ``` GET / HTTP/1.1 Host: minio:9000 User-Agent: MinIO (linux; amd64) minio-go/v7.0.61 Authorization: AWS4-HMAC-SHA256 Credential=123456/20230831/badregion/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=a0c9454bdfc0187f76c4c58ac881c9feea7a9d539c5d6b48b5a0d8fca0621f9b X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 X-Amz-Date: 20230831T194154Z Accept-Encoding: gzip 21:41:54.333195 IP localhost.9000 > localhost.45112: Flags [.], ack 443, win 509, options [nop,nop,TS val 3843120214 ecr 3843120214], length 0 E..4IP@.@..q........#(.8g............(..... ..\V..\V 21:41:54.333380 IP localhost.9000 > localhost.45112: Flags [P.], seq 1:363, ack 443, win 512, options [nop,nop,TS val 3843120214 ecr 3843120214], length 362 E...IQ@.@...........#(.8g.................. ..\V..\VHTTP/1.1 400 Bad Request content-type: application/xml content-length: 245 date: Thu, 31 Aug 2023 19:41:54 GMT <?xml version="1.0" encoding="UTF-8"?><Error><Code>AuthorizationHeaderMalformed</Code><Message>Authorization header malformed, unexpected scope: 20230831/badregion/s3/aws4_request</Message><Resource>/</Resource><Region>us-east-1</Region></Error> ```
earl-warren changed title from Payload on 400 error to Payload on 400 error for HEAD requests 2023-08-31 20:00:01 +00:00
earl-warren commented 2023-08-31 20:08:02 +00:00
Author
Copy link

I'm not sure which way to go to resolve this. I think I'll use a GET request to indirectly assert the region is valid and display a meaningful error message if it does not, using the 400 payload.

But it feels like a hack and there should be a more idiomatic way to do that.

Thoughts?

I'm not sure which way to go to resolve this. I think I'll use a GET request to indirectly assert the region is valid and display a meaningful error message if it does not, using the 400 payload. But it feels like a hack and there should be a more idiomatic way to do that. Thoughts?
earl-warren commented 2023-08-31 20:13:28 +00:00
Author
Copy link

https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html

This action is useful to determine if a bucket exists and you have permission to access it. The action returns a 200 OK if the bucket exists and you have permission to access it.

If the bucket does not exist or you do not have permission to access it, the HEAD request returns a generic 400 Bad Request, 403 Forbidden or 404 Not Found code. A message body is not included, so you cannot determine the exception beyond these error codes.

In any case garage behaves like AWS S3 in that instance and this issue can be closed.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html > This action is useful to determine if a bucket exists and you have permission to access it. The action returns a 200 OK if the bucket exists and you have permission to access it. > > If the bucket does not exist or you do not have permission to access it, the HEAD request returns a generic 400 Bad Request, 403 Forbidden or 404 Not Found code. A message body is not included, so you cannot determine the exception beyond these error codes. In any case garage behaves like AWS S3 in that instance and this issue can be closed.
lx commented 2023-09-01 11:01:48 +00:00
Owner
Copy link

What we are still missing is the x-amz-bucket-region though. I'm not sure how it is used by minio to detect the correct region but we should probably add it to garage anyway

What we are still missing is the `x-amz-bucket-region` though. I'm not sure how it is used by minio to detect the correct region but we should probably add it to garage anyway
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
update-dependencies-1.1
feat-metrics-metadata-engine
improve-secret-error-message
hotfix/1.0.0-rc1-red-ftr-wquorum
main-0.9.x
db-no-unsafe
main-0.8.x
k2v/shared_http_client
feat/website-redir
smithy2
test/compilation
poc/nomad-ci
test-ci-wait
pnet_datalink-0.33.0
optimal-layout
k2v-watch-range
db-debug-log
build-convert-db
demonstrate-cargo2nix-bug
dangerous/no-fsync
dev0.7.3
doc/benchmarks
bug/check_static
bucket-cors-more
storage-optimizations
old-main
v1.0.1
v1.0.0
v0.9.4
v1.0.0-rc1
v0.8.7
v0.9.3
v0.9.2
v0.8.6
v0.9.2-rc1
v0.9.1
v0.8.5
v0.10.0-beta1
v0.9.0
v0.9.0-rc2
v0.9.0-rc1
v0.9.0-beta4
v0.9.0-beta3
v0.9.0-beta2
v0.8.4
v0.9.0-beta1
v0.8.3
v0.8.3-rc1
format_table-v0.1.1
format_table-v0.1.0
v0.8.2
v0.8.1
v0.8.0
v0.8.0-rc2
v0.8.0-rc1
v0.8.0-dangerous-no-fsync
v0.8.0-beta2-k2v
v0.8.0-beta2
v0.8.0-beta1-k2v
v0.8.0-beta1
v0.7.99.3-k2v
v0.7.3
v0.7.3-beta2
v0.7.3-beta1
v0.7.2.1
v0.7.2
v0.7.2_ci-test-2
v0.7.2+ci-test-version
v0.7.99.2-k2v
v0.7.99.1-k2v
v0.7.99-k2v
v0.7.2-k2v
v0.7.1-admin-k2v-2
v0.7.1-admin-k2v
v0.7.1-k2v
v0.7.1
v0.7.0
v0.7.0-rc1
v0.6.1
v0.6.0
v0.6.0-rc1
v0.5.1
v0.5.0.1
v0.5.0
v0.5-beta1
v0.4.0
v0.4-rc2
v0.4-rc1
0.4-beta
0.4-alpha
v0.3.0.2
v0.3.0.1
v0.3.0
v0.2.1.5
v0.2.1
v0.2.0
0.1.1b
0.1.1
0.1.0b
0.1.0
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#624
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?