Add config option for bind ip for outgoing connections #638

New issue

Closed

opened 2023-09-26 16:54:12 +00:00 by yuka · 2 comments

yuka commented

2023-09-26 16:54:12 +00:00

Contributor

No description provided.

lx commented

2023-10-16 09:37:27 +00:00

Owner

Could you write a more exhaustive documentation for this feature request? I can't keep open a feature request if I don't know what it is about.

yuka commented

2023-11-04 11:29:31 +00:00

Author

Contributor

consider the following patch applied to the netapp dependency:

diff --git a/src/netapp.rs b/src/netapp.rs
index b1ad9db..cdd81ba 100644
--- a/src/netapp.rs
+++ b/src/netapp.rs
@@ -13,7 +13,7 @@ use sodiumoxide::crypto::sign::ed25519;
 
 use futures::stream::futures_unordered::FuturesUnordered;
 use futures::stream::StreamExt;
-use tokio::net::{TcpListener, TcpStream};
+use tokio::net::{TcpListener, TcpStream, TcpSocket};
 use tokio::select;
 use tokio::sync::{mpsc, watch};
 
@@ -298,9 +298,19 @@ impl NetApp {
            return Ok(());
        }
 
-       let socket = TcpStream::connect(ip).await?;
+       let stream = if let Some(listen_addr) = self.listen_params.load().as_ref().map(|par| par.listen_addr) {
+           let socket = if listen_addr.is_ipv4() {
+               TcpSocket::new_v4()
+           } else {
+               TcpSocket::new_v6()
+           }?;
+           socket.bind(SocketAddr::new(listen_addr.ip(), 0))?;
+           socket.connect(ip).await?
+       } else {
+           TcpStream::connect(ip).await?
+       };
        info!("Connected to {}, negotiating handshake...", ip);
-       ClientConn::init(self, socket, id).await?;
+       ClientConn::init(self, stream, id).await?;
        Ok(())
    }

In this case I bind a TcpSocket to the listen_addr before making outgoing connections.

The use case is a node that has multiple IP addresses, but only one is allowed/able to reach the other nodes because of firewall/routing reasons.

consider the following patch applied to the netapp dependency: ```diff diff --git a/src/netapp.rs b/src/netapp.rs index b1ad9db..cdd81ba 100644 --- a/src/netapp.rs +++ b/src/netapp.rs @@ -13,7 +13,7 @@ use sodiumoxide::crypto::sign::ed25519; use futures::stream::futures_unordered::FuturesUnordered; use futures::stream::StreamExt; -use tokio::net::{TcpListener, TcpStream}; +use tokio::net::{TcpListener, TcpStream, TcpSocket}; use tokio::select; use tokio::sync::{mpsc, watch}; @@ -298,9 +298,19 @@ impl NetApp { return Ok(()); } - let socket = TcpStream::connect(ip).await?; + let stream = if let Some(listen_addr) = self.listen_params.load().as_ref().map(|par| par.listen_addr) { + let socket = if listen_addr.is_ipv4() { + TcpSocket::new_v4() + } else { + TcpSocket::new_v6() + }?; + socket.bind(SocketAddr::new(listen_addr.ip(), 0))?; + socket.connect(ip).await? + } else { + TcpStream::connect(ip).await? + }; info!("Connected to {}, negotiating handshake...", ip); - ClientConn::init(self, socket, id).await?; + ClientConn::init(self, stream, id).await?; Ok(()) } ``` In this case I bind a TcpSocket to the listen_addr before making outgoing connections. The use case is a node that has multiple IP addresses, but only one is allowed/able to reach the other nodes because of firewall/routing reasons.