doc: update endpoint_url documentation #641

Merged

lx merged 1 commits from flokli/garage:aws-endpoint-url into main

2023-10-02 14:30:54 +00:00

flokli commented

2023-10-02 12:16:13 +00:00

Contributor

Since awscli >=1.29.0 or >=2.13.0 it is now possible to use the
AWS_ENDPOINT_URL environment variable, or the endpoint_url config
key to override the endpoint URL. This means, the aws bash function to
wrap with --endpoint-url is not necessary anymore. Update invocations to
reflect that.

https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
https://github.com/aws/aws-cli/issues/4454#issuecomment-1626116607

Since `awscli` `>=1.29.0` or `>=2.13.0` it is now possible to use the `AWS_ENDPOINT_URL` environment variable, or the `endpoint_url` config key to override the endpoint URL. This means, the aws bash function to wrap with --endpoint-url is not necessary anymore. Update invocations to reflect that. https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html https://github.com/aws/aws-cli/issues/4454#issuecomment-1626116607

flokli commented

2023-10-02 12:22:55 +00:00

Author

Contributor

I'm not sure about the CI failure, if it's unrelated or not, and I can't rekick it from my side.

trinity-1686a commented

2023-10-02 12:39:02 +00:00

Owner

I retried the CI and it still fails. There is an error at log line 176 (there doesn't appear to be an anchor to link directly to it :-/ ).

CI appears to be using aws-cli 2.11.6, I'm not sure how to upgrade, but that's probably why.

I retried the CI and it still fails. There is an error at log line 176 (there doesn't appear to be an anchor to link directly to it :-/ ). CI appears to be using aws-cli 2.11.6, I'm not sure how to upgrade, but that's probably why.

flokli commented

2023-10-02 14:14:33 +00:00

Author

Contributor

Ah, in that case we'd probably need to do a nixpkgs bump (which would however also bump rustc)

I guess I can just revert the change in dev-env-aws.sh for now, and add a TODO to update this on the next nixpkgs bump.

Ah, in that case we'd probably need to do a nixpkgs bump (which would however also bump rustc) I guess I can just revert the change in `dev-env-aws.sh` for now, and add a TODO to update this on the next nixpkgs bump.

flokli force-pushed aws-endpoint-url from 04a1b6513d to cb359b4434

2023-10-02 14:16:15 +00:00

Compare

lx commented

2023-10-02 14:30:02 +00:00

Owner

Awscli 2.13 is not yet available in nixpkgs stable (it's in unstable, though, so should be in nixpkgs 23.11). Also, upgrading our nixpkgs dependency is a big task with many complications, so let's handle that separately.

👍 1