path style looks broken in 0.9.0 #673
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#673
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
when doing a request to 0.9.0 in path style mode it will fail if the request is like that:
it fails with:
what works if there is a
/
at the end:in fact the same call worked on 0.8.x. unfortunatly wal-g does not add the trailing
/
and thus would fail in cases like that.actually wal-g uses
aws-sdk-go/1.44.7
maybe that is in itself a problem.if a
/
is important, the code that would be faulty would probably be in router.rs, but it looks fine, and untouched for a long time.Are you sure nothing else than that
/
changes between a successful and an unsuccessful query? What is theHost:
header in both cases, and what is the value ofs3_api.root_domain
(if any) in your configuration file?the one that is not working has the following inside the
s3_api.root_domain
:but I can probably remove the root domain, since it is not in use. maybe thats probably also the problem since the client will go to:
garage.garage.svc.cluster.local
really really good catch @trinity-1686a that probably helped, I will try that out later.The working one has
.s3.envisia.net
and the clients usegarage.garage.svc.cluster.local
as well.with a root_domain of
garage.svc.cluster.local
, and a query forgarage.garage.svc.cluster.local
, Garage will remove the suffix and consider that the first "garage" is the bucket name (vhost style). Withs3.envisia.net
andgarage.garage.svc.cluster.local
, the suffix mismatches so Garage tries path-style@trinity-1686a thanks! that helped. Now everything works!