Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

Cargo.toml: Enable full LTO in release builds and thin in dev builds. #704

Merged
lx merged 1 commits from jpds/garage:release-build-lto into main 2024-02-07 16:37:03 +00:00
Conversation 2 Commits 1 Files Changed 1 +5 -2
jpds commented 2024-02-07 16:14:39 +00:00
Contributor
Copy Link

Optimizations picked from cloud-hypervisor project: https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/Cargo.toml#L20-L24

Binary sizes:

-rwxr-xr-x. 1 build build  17M Feb  7 16:01 ../garage-lto*
-rwxr-xr-x. 2 build build 689M Feb  7 16:09 target/release/garage*
Optimizations picked from `cloud-hypervisor` project: https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/Cargo.toml#L20-L24 Binary sizes: ``` -rwxr-xr-x. 1 build build 17M Feb 7 16:01 ../garage-lto* -rwxr-xr-x. 2 build build 689M Feb 7 16:09 target/release/garage* ```
jpds added 1 commit 2024-02-07 16:14:40 +00:00
lx commented 2024-02-07 16:35:36 +00:00
Owner
Copy Link

Thanks, LGTM. I think for the moment this will not be taken into account in the Nix build process that builds release binaries, we'll have to look into that.

Thanks, LGTM. I think for the moment this will not be taken into account in the Nix build process that builds release binaries, we'll have to look into that.
lx merged commit 59930977e0 into main 2024-02-07 16:37:03 +00:00
lx commented 2024-02-08 09:18:49 +00:00
Owner
Copy Link

I think thin LTO is adding at least a few minutes to our debug builds which is pretty annoying for the CI, so I will disable it on debug for now.

I think thin LTO is adding at least a few minutes to our debug builds which is pretty annoying for the CI, so I will disable it on debug for now.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#704
No description provided.
Delete Branch "jpds/garage:release-build-lto"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?