ACL header get converted to x-amz-acl #825

New issue

Open

opened 2024-05-21 11:35:40 +00:00 by tcheronneau · 1 comment

tcheronneau commented

2024-05-21 11:35:40 +00:00

At this line there is a change of header for the acl : https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3/post_object.rs#L76.
And then in the code you do some comparison : https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3/post_object.rs#L192 that would match the ACL header.
But since it was converted to x-amz-acl it's not working (acl != x-amz-acl).
I've did a patch locally to try with the code L76 (I've been running it for a while and everything seems fine).

This issue prevent outline (https://www.getoutline.com/) to work correctly.
I'm not a rust expert so I could be wrong and it could be there for a reason but I don't see how it can work in the current state.

At this line there is a change of header for the acl : https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3/post_object.rs#L76. And then in the code you do some comparison : https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3/post_object.rs#L192 that would match the ACL header. But since it was converted to x-amz-acl it's not working (acl != x-amz-acl). I've did a patch locally to try with the code L76 (I've been running it for a while and everything seems fine). This issue prevent outline (https://www.getoutline.com/) to work correctly. I'm not a rust expert so I could be wrong and it could be there for a reason but I don't see how it can work in the current state.