Rust 1.80 breaks garage build #849

New issue

Closed

opened 2024-08-07 10:45:54 +00:00 by teutat3s · 3 comments

teutat3s commented

2024-08-07 10:45:54 +00:00

Contributor

alyssais discovered that Rust 1.80.0 contains a couple of changes that break the build for garage. I'm opening this issue to coordinate efforts to make garage ready for 1.80.0.

Citing the linked issue:

Figure out what's broken. Usually, but not always, this is that the "time" crate needs to be updated.

   Compiling time v0.3.34
error[E0282]: type annotations needed for `Box<_>`

Full build logs for Garage 1.0.0
https://hydra.nixos.org/build/268878343/nixlog/1

Full build logs for Garage 0.8.7
https://hydra.nixos.org/build/268753102/nixlog/1

It looks like #847 is already bumping the time crate, so that might be all that's needed.

[alyssais discovered](https://github.com/NixOS/nixpkgs/issues/332957) that Rust 1.80.0 contains a couple of changes that break the build for `garage`. I'm opening this issue to coordinate efforts to make garage ready for 1.80.0. Citing the linked issue: > Figure out what's broken. Usually, but not always, this is that the "time" crate needs to be updated. ``` Compiling time v0.3.34 error[E0282]: type annotations needed for `Box<_>` ``` Full build logs for Garage 1.0.0 https://hydra.nixos.org/build/268878343/nixlog/1 Full build logs for Garage 0.8.7 https://hydra.nixos.org/build/268753102/nixlog/1 It looks like https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/847 is already bumping the `time` crate, so that might be all that's needed.

quentin added the

labels 2024-08-07 10:50:38 +00:00

maximilien commented

2024-08-07 21:59:00 +00:00

Owner

The branche builds fine with rust 1.80.0, the actual nix toolchain update only use rust 1.77.2 as we're pulling from nixpkg 24.05, but I guess once we merge it staging-next should build as well. Do you have any kind of timeline we should consider? I take that staging-next is to become 24.11?

The branche builds fine with rust 1.80.0, the actual nix toolchain update only use rust 1.77.2 as we're pulling from nixpkg 24.05, but I guess once we merge it `staging-next` should build as well. Do you have any kind of timeline we should consider? I take that staging-next is to become 24.11?

maximilien self-assigned this 2024-08-07 21:59:09 +00:00

maximilien added this to the v1.1 milestone 2024-08-07 21:59:12 +00:00

yuka commented

2024-08-08 07:38:42 +00:00

Contributor

staging-next will become nixos-unstable in around a week, and there is a compile error in anything that uses the time crate < 0.3.35: https://github.com/NixOS/nixpkgs/issues/332957

staging-next will become nixos-unstable in around a week, and there is a compile error in anything that uses the `time` crate < 0.3.35: https://github.com/NixOS/nixpkgs/issues/332957

teutat3s commented

2024-08-14 12:22:17 +00:00

Author

Contributor

staging-next has been merged today. https://github.com/NixOS/nixpkgs/pull/332764

`staging-next` has been merged today. https://github.com/NixOS/nixpkgs/pull/332764