garage omit Location in CompleteMultipartUploadResult cause minio js client failed to parse #852

New issue

Open

opened 2024-08-13 10:20:17 +00:00 by wener · 1 comment

wener commented

2024-08-13 10:20:17 +00:00

garage

location: None,

MinioJS
d08e54a391/src/internal/xml-parser.ts (L282-L303)

The response demo

<?xml version="1.0" encoding="UTF-8"?>
<CompleteMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <Bucket>X</Bucket>
    <Key>X</Key>
    <ETag>&quot;572e7a853374de6582ca2b0bc03486e1-1&quot;</ETag>
</CompleteMultipartUploadResult>

xref https://github.com/minio/minio-js/issues/1332

garage https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/3a87bd1370eb9fefc67deec9d7dfa2187ddf9763/src/api/s3/multipart.rs#L432 MinioJS https://github.com/minio/minio-js/blob/d08e54a391adb8fe6630c8cfde66621d6f37b777/src/internal/xml-parser.ts#L282-L303 The response demo ```xml <?xml version="1.0" encoding="UTF-8"?> <CompleteMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"> <Bucket>X</Bucket> <Key>X</Key> <ETag>"572e7a853374de6582ca2b0bc03486e1-1"</ETag> </CompleteMultipartUploadResult> ``` xref https://github.com/minio/minio-js/issues/1332

quentin added the

labels 2024-08-29 09:49:32 +00:00

quentin commented

2024-08-29 09:52:17 +00:00

Owner

Could you provide a link to a simple node.js project that triggers this issue with Garage please? (to allow us to easily reproduce the bug and test a patch?). Otherwise, I think that's indeed something we can fix quite easily.

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#852

No description provided.