Tracing context should be propagated from the upstream #867

Open
opened 2024-08-26 19:15:36 +00:00 by farcaller · 0 comments

If tracing is enabled I expect garage to honor the OTEL headers in the request for the parent stream, however it seems that garage doesn't include any parent scope in the tracing consideration.

Can you please add the relevant http context extractors to the endpoints? It seems that this is a good starting point.

I ok with contributing code for this change, too, as long as you tell me if you accept the external contributions and what format you expect.

If tracing is enabled I expect garage to honor the OTEL headers in the request for the parent stream, however it seems that garage doesn't include any parent scope in the tracing consideration. Can you please add the relevant http context extractors to the endpoints? It seems that [this](https://github.com/open-telemetry/opentelemetry-rust/blob/main/examples/tracing-http-propagator/src/server.rs#L63) is a good starting point. I ok with contributing code for this change, too, as long as you tell me if you accept the external contributions and what format you expect.
quentin added the
kind
usability
scope
ops
action
triage-required
labels 2024-08-29 09:38:58 +00:00
quentin added
scope
telemetry
and removed
scope
ops
labels 2024-08-29 09:40:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#867
No description provided.