Deuxfleurs/garage
47
55
Fork 70
Code Issues 98 Pull requests 13 Releases 30 Wiki Activity

KV: don't retrieve values for write ops #873

Merged
lx merged 3 commits from marvinj97/garage:perf/kv/insert-no-return into main 2024-09-10 09:06:29 +00:00
Conversation 2 Commits 3 Files changed 4 +15 -26
marvinj97 commented 2024-09-04 16:50:44 +00:00
Contributor
Copy link

As described in #851, return values in KV write ops are never used, so it is unnecessarily performing read ops (possibly with disk I/O) in the write hot path. But I haven't benchmarked the change in performance.

SQLite could probably use INSERT ... ON CONFLICT(REPLACE)

As described in https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/851, return values in KV write ops are never used, so it is unnecessarily performing read ops (possibly with disk I/O) in the write hot path. But I haven't benchmarked the change in performance. SQLite could probably use INSERT ... ON CONFLICT(REPLACE)
marvinj97 added 1 commit 2024-09-04 16:50:45 +00:00
perf(kv): dont retrieve values for write ops
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
74363c9060 
see #851
marvinj97 added 1 commit 2024-09-04 16:52:14 +00:00
dont assert deletion count in sqlite KV adapter
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
eb416a02fb
marvinj97 added 1 commit 2024-09-04 17:24:39 +00:00
test: fix db tests
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
8062ec7b4b
withings commented 2024-09-05 08:51:26 +00:00
Contributor
Copy link

Darn, you beat me to it ^^ That does feel like a good improvement!

For reference, here is a little PutObject benchmark for this change.

Before (as seen in #851) :

image

With this change :

image

There does appear to be a performance benefit: the second benchmark stays above 500#/s for longer.

I have got the diff for the INSERT OR REPLACE in SQLite but I don't really have benchmark data for it, so I can't say how that would perform.

JKR

Darn, you beat me to it ^^ That does feel like a good improvement! For reference, here is a little PutObject benchmark for this change. Before (as seen in #851) : ![image](/attachments/3d25cce4-4c9f-419a-a44f-b6fc68422432) With this change : ![image](/attachments/9b851d80-5188-45f6-ab07-6ce2da1c2894) There does appear to be a performance benefit: the second benchmark stays above 500#/s for longer. I have got the diff for the `INSERT OR REPLACE` in SQLite but I don't really have benchmark data for it, so I can't say how that would perform. JKR
image.png
48 KiB
image.png
36 KiB
marvinj97 commented 2024-09-05 12:11:20 +00:00
Author
Contributor
Copy link

@withings The benchmark images are broken unfortunately

@withings ~~The benchmark images are broken unfortunately~~
👍 1
lx approved these changes 2024-09-10 09:06:23 +00:00
lx left a comment
Owner
Copy link

LGTM

LGTM
lx merged commit 586957b4b7 into main 2024-09-10 09:06:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#873
No description provided.
Delete branch "marvinj97/garage:perf/kv/insert-no-return"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?