Deuxfleurs/garage
48
56
Fork 73
Code Issues 99 Pull requests 13 Releases 30 Wiki Activity

Unit Tests #9

Merged
lx merged 4 commits from feature/unit-tests into master 2020-11-08 12:41:00 +00:00
Conversation 3 Commits 4 Files changed 1 +46 -9
quentin commented 2020-11-07 12:58:36 +00:00
Owner
Copy link

There are (at least) 3 class of tests in Rust:

  • Unit Tests
  • Integration Tests
  • Documentation Tests

When reading the code, I wanted to really understand how parse_bucket_key works and it appears that tests are really great at explaining such things.
Ideally, I wanted to write a documentation tests, to explain at the same time with a natural language how it works. However it appears that documentation tests can not easily be used with private functions, which explains why I fell back to unit tests.

I don't know how we want to work: merge unit tests one by one or in a batch? With or without PR?
So let's start the discussion here!

There are (at least) 3 class of tests in Rust: - Unit Tests - Integration Tests - Documentation Tests When reading the code, I wanted to really understand how `parse_bucket_key` works and it appears that tests are really great at explaining such things. Ideally, I wanted to write a documentation tests, to explain at the same time with a natural language how it works. However it appears that documentation tests can not easily be used with private functions, which explains why I fell back to unit tests. I don't know how we want to work: merge unit tests one by one or in a batch? With or without PR? So let's start the discussion here!
lx commented 2020-11-07 13:16:34 +00:00
Owner
Copy link

It's probably better to do a PR so that I can check that the test is correct. If you're done writing tests for now, don't wait to make a PR. If you're writing a series of tests for a bunch of functions in the same module, make a single PR for them.

It's probably better to do a PR so that I can check that the test is correct. If you're done writing tests for now, don't wait to make a PR. If you're writing a series of tests for a bunch of functions in the same module, make a single PR for them.
quentin changed title from WIP: Unit Tests to Unit Tests 2020-11-07 14:35:14 +00:00
quentin commented 2020-11-07 14:36:39 +00:00
Author
Owner
Copy link

Done for today, I added a second test, you can merge.

What is the point of returning a result in this function as there is no way this function can fail?

Done for today, I added a second test, you can merge. What is the point of returning a result in this function as there is no way this function can fail?
lx commented 2020-11-08 12:24:10 +00:00
Owner
Copy link

Because there is a bug. The function should fail if bucket is the empty string.

Because there is a bug. The function should fail if bucket is the empty string.
lx merged commit 18aab38a6a into master 2020-11-08 12:40:59 +00:00
quentin deleted branch feature/unit-tests 2020-11-08 14:54:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#9
No description provided.
Delete branch "feature/unit-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?