Helm chart: Add garage.existingConfigmap and replace garage.garage.toml with garage.garageTomlString #923

Merged
maximilien merged 2 commits from jessebot/garage:allow-existing-configmap into main 2025-01-15 23:53:25 +00:00
Contributor

This fixes #922

Helm chart updates

  • New helm parameter, garage.existingConfigmap to use an existing ConfigMap for garage.toml:

    garage:
      existingConfigmap: ""
    
  • Added some autogenerated docs using helm-docs. It works by processing every comment that starts with # -- I'm a comment as a description for the parameter it is directly above. This gives a small chart in a README that users can reference in the same directory as the chart.

Changes

  • Replaces garage.garage.toml with garage.garageTomlString. You can still use the old feature like this:

    garage:
      garageTomlString: |-
        myconfig = "somegreatconfig"    
    

    This also moves all the configuration back to the ConfigMap template file so that no GoTemplating happens in the values.yaml itself.

This fixes https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/922 **Helm chart updates** - New helm parameter, `garage.existingConfigmap` to use an existing ConfigMap for garage.toml: ```yaml garage: existingConfigmap: "" ``` - Added some autogenerated docs using helm-docs. It works by processing every comment that starts with `# -- I'm a comment` as a description for the parameter it is directly above. This gives a small chart in a README that users can reference in the same directory as the chart. **Changes** - Replaces `garage.garage.toml` with `garage.garageTomlString`. You can still use the old feature like this: ```yaml garage: garageTomlString: |- myconfig = "somegreatconfig" ``` This also moves all the configuration back to the ConfigMap template file so that no GoTemplating happens in the values.yaml itself.
jessebot added 1 commit 2025-01-09 11:21:02 +00:00
Add garage.existingConfigmap and replace garage.garage.toml with garage.garageTomlString
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
b94acb1114
also moves all gotemplating back to configmap

and adds autogenerated docs via helm-docs

Signed-off-by: jessebot <jessebot@linux.com>
jessebot changed title from Add garage.existingConfigmap and replace garage.garage.toml with garage.garageTomlString to Helm chart: Add garage.existingConfigmap and replace garage.garage.toml with garage.garageTomlString 2025-01-09 11:34:41 +00:00
maximilien requested review from maximilien 2025-01-09 21:52:30 +00:00
maximilien added the
scope
k8s
label 2025-01-09 21:52:34 +00:00
maximilien added 1 commit 2025-01-15 23:46:48 +00:00
Minor rewording, add some more hints
Some checks are pending
ci/woodpecker/pr/debug Pipeline is pending
b35eca673c
maximilien approved these changes 2025-01-15 23:50:47 +00:00
maximilien force-pushed allow-existing-configmap from b35eca673c to 58a765c51f 2025-01-15 23:51:09 +00:00 Compare
maximilien merged commit 255b01b626 into main 2025-01-15 23:53:25 +00:00
jessebot deleted branch allow-existing-configmap 2025-01-16 06:49:27 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#923
No description provided.