admin refactoring: refactor CLI to use Admin API requests (step 2) #943

Merged

lx merged 9 commits from refactor-admin into next-v2 2025-01-30 16:18:39 +00:00

Conversation 0 Commits 9 Files changed 19 +1485 -1414

lx commented 2025-01-30 11:08:28 +00:00

Owner

Copy link

• Make admin API calls available through internal RPC (proxy them through admin RPC)
• use them in the CLI as much as possible
• proof-reading
• testing

for step3:

• Convert any functionnality that was only in the CLI into now-standardized admin API calls
• Update OpenAPI specification again

for step4: (in nlnet task5)

• Make the CLI able to call the admin API through HTTP as well

- [x] Make admin API calls available through internal RPC (proxy them through admin RPC) - [x] use them in the CLI as much as possible - [ ] proof-reading - [ ] testing for step3: - [ ] Convert any functionnality that was only in the CLI into now-standardized admin API calls - [ ] Update OpenAPI specification again for step4: (in nlnet task5) - [ ] Make the CLI able to call the admin API through HTTP as well

lx added 2 commits 2025-01-30 11:08:28 +00:00

wip: proxy admin api requests through admin rpc, prepare new cli 145130481e

wip: migrate garage status and garage layout assign 69ddaafc60

lx added 1 commit 2025-01-30 11:19:37 +00:00

cli: migrate layout remove, apply, revert 819f4f0050

lx added 1 commit 2025-01-30 12:36:36 +00:00

admin api: convert most bucket operations f37d5d2b08

lx added 1 commit 2025-01-30 14:38:32 +00:00

fix garage status output 076ce04fe5

lx added 1 commit 2025-01-30 15:12:27 +00:00

convert cli key operations to admin rpc f8c6a8373d

lx added 1 commit 2025-01-30 15:17:45 +00:00

cli_v2: error messages ebc0e9319e

lx added 2 commits 2025-01-30 15:40:16 +00:00

cli_v2: merge util.rs into layout.rs 3caea5fc06

cli_v2: fix garage status 1ee8e6f1a6

lx added this to the v2.0 milestone 2025-01-30 15:42:34 +00:00

lx force-pushed refactor-admin from 1ee8e6f1a6 to 5a89350b38 2025-01-30 15:46:04 +00:00 Compare

lx changed title from WIP: refactor CLI to use Admin API requests (step 1) to refactor CLI to use Admin API requests (step 1) 2025-01-30 16:16:09 +00:00

lx changed title from refactor CLI to use Admin API requests (step 1) to admin refactoring: refactor CLI to use Admin API requests (step 2) 2025-01-30 16:16:23 +00:00

lx merged commit 3192088aac into next-v2 2025-01-30 16:18:39 +00:00

lx referenced this pull request from a commit 2025-01-30 16:18:39 +00:00

Merge pull request 'admin refactoring: refactor CLI to use Admin API requests (step 2)' (#943) from refactor-admin into next-v2

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

action

check-aws

The behaviour should be checked against AWS S3

  

action

discussion-needed

We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  

action

for-external-contributors

Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  

action

for-newcomers

An issue that should be newcomer friendly.

  

action

more-info-needed

More information is needed to investigate this issue

  

action

need-funding

This issue represents lots of work, we need to find money to pay our core team work

  

action

triage-required

It's not very clear what we want to do with this issue yet, more thoughts is required

  

kind

correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

kind

ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

kind

improvement

Feature requests that do not fall in other categories

  

kind

performance

Deceptive performance observed OR idea to improve performances

  

kind

testing

Functional tests, integration tests, Jepsen, etc.

  

kind

usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  

kind

wrong-behavior

Unintended behavior

  

prio

critical

Could impact integrity or availability of production clusters

  

prio

low

For issues that we don't want to spend time on until made absolutely necessary

  

scope

admin-api

Issues concerning the administration API

  

scope

background-healing

Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  

scope

build

Issues with Nix, Drone, Rust Compiler, etc.

  

scope

documentation

  

scope

k8s

Kubernetes related, including Helm Charts

  

scope

layout

Linked to the cluster layout and storage management

  

scope

metadata

Metadata Engine (LMDB, sqlite, etc.)

  

scope

ops

Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  

scope

rpc

Linked to RPC

  

scope

s3-api

Related to the S3 API (especially compatibility issues).

  

scope

security

Cryptography-related, auth-related, authorization-related issues

  

scope

telemetry

OpenTelemetry (traces, metrics, etc.)

No labels

action

check-aws

action

discussion-needed

action

for-external-contributors

action

for-newcomers

action

more-info-needed

action

need-funding

action

triage-required

kind

correctness

kind

ideas

kind

improvement

kind

performance

kind

testing

kind

usability

kind

wrong-behavior

prio

critical

prio

low

scope

admin-api

scope

background-healing

scope

build

scope

documentation

scope

k8s

scope

layout

scope

metadata

scope

ops

scope

rpc

scope

s3-api

scope

security

scope

telemetry

Milestone

Clear milestone

No items

No milestone

v2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#943

No description provided.