Deuxfleurs/garage
32
59
Fork 80
Code Issues 100 Pull requests 17 Releases 30 Wiki Activity

Admin API refactoring: convert existing commands to API requests (step 3) #945

Merged
lx merged 12 commits from refactor-admin into next-v2 2025-02-05 19:54:42 +00:00
Conversation 0 Commits 12 Files changed 39 +2236 -1530
lx commented 2025-01-30 16:51:26 +00:00
Owner
Copy link

for step3:

  • Convert any functionnality that was only in the CLI into now-standardized admin API calls
    • admin rpc
      • CleanupIncompleteUploads
      • Get/SetWorkerVariable
      • ListWorkers
      • GetWorkerInfo
      • LaunchRepairOperation
      • GetNodeStats
      • GetClusterStats
      • CreateMetadataSnapshot
      • ListBlockErrors
      • GetBlockInfo
      • RetryBlockResync
      • PurgeBlocks
    • standard rpc
      • GetClusterLayoutHistory
      • PreviewClusterLayoutChanges
      • ForceClusterLayoutSkipDeadNodes
  • Update documentation and OpenAPI specification again

for step4: (in nlnet task5)

  • Make the CLI able to call the admin API through HTTP as well
for step3: - [ ] Convert any functionnality that was only in the CLI into now-standardized admin API calls - admin rpc - [x] CleanupIncompleteUploads - [x] Get/SetWorkerVariable - [x] ListWorkers - [x] GetWorkerInfo - [x] LaunchRepairOperation - [x] GetNodeStats - [x] GetClusterStats - [x] CreateMetadataSnapshot - [x] ListBlockErrors - [x] GetBlockInfo - [x] RetryBlockResync - [x] PurgeBlocks - standard rpc - [ ] GetClusterLayoutHistory - [ ] PreviewClusterLayoutChanges - [ ] ForceClusterLayoutSkipDeadNodes - [ ] Update documentation and OpenAPI specification again for step4: (in nlnet task5) - [ ] Make the CLI able to call the admin API through HTTP as well
lx added 2 commits 2025-01-30 16:51:26 +00:00
admin api: add CleanupIncompleteUploads spec
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
3018dfd663
lx added 3 commits 2025-01-30 18:38:26 +00:00
wip: infrastructure for local api calls
Some checks failed
ci/woodpecker/push/debug Pipeline failed
Details
d0c94e8bdf
lx force-pushed refactor-admin from d0c94e8bdf to e3d1571247 2025-01-30 18:41:17 +00:00 Compare
lx added 1 commit 2025-01-30 19:01:44 +00:00
admin api: fix things
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
ci/woodpecker/push/debug Pipeline failed
Details
a5882c3875
lx force-pushed refactor-admin from a5882c3875 to bb36360c0b 2025-01-30 19:03:13 +00:00 Compare
lx added 1 commit 2025-01-30 19:31:05 +00:00
admin api: first local endpoint to work with new scheme
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
783c1e1c70
lx added 1 commit 2025-01-30 19:39:24 +00:00
admin api: implement SetWorkerVariable
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
cf30ae8b99
lx added 1 commit 2025-01-31 14:39:46 +00:00
cli_v2: implement ListWorkers and GetWorkerInfo
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
27012155ba
lx force-pushed refactor-admin from 27012155ba to e93e825224 2025-01-31 14:41:39 +00:00 Compare
lx added 1 commit 2025-01-31 14:53:12 +00:00
cli_v2: add local_api_request with crazy type bound
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
4f2af8cab9
lx added 1 commit 2025-01-31 15:53:55 +00:00
cli_v2: implement ListBlockErrors and GetBlockInfo
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
af648b4fae
lx added 1 commit 2025-01-31 16:19:37 +00:00
cli_v2: implement RetryBlockResync and PurgeBlocks
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
1533084241
lx added 1 commit 2025-01-31 16:52:01 +00:00
admin api: impl RequestHandler for MetricsRequest
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
421bb6a610
lx changed title from Admin API refactoring: convert existing commands to API requests (step 3) to WIP: Admin API refactoring: convert existing commands to API requests (step 3) 2025-01-31 18:17:01 +00:00
lx force-pushed refactor-admin from 421bb6a610 to 92d10bb47d 2025-02-01 18:15:19 +00:00 Compare
lx force-pushed refactor-admin from 92d10bb47d to 5cbb6e0fc9 2025-02-01 18:32:47 +00:00 Compare
lx added 1 commit 2025-02-01 18:37:28 +00:00
admin api: reorder things
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
4a3e964ecc
lx force-pushed refactor-admin from 4a3e964ecc to ce2935c82d 2025-02-01 18:58:48 +00:00 Compare
lx force-pushed refactor-admin from ce2935c82d to 97be7b38fa 2025-02-03 17:55:00 +00:00 Compare
lx added 1 commit 2025-02-05 13:22:22 +00:00
cli_v2: implement CreateMetadataSnapshot
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
9f468b4439
lx added 1 commit 2025-02-05 14:06:21 +00:00
cli_v2: implement Get{Node,Cluster}Statistics
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
406b6da163
lx added 1 commit 2025-02-05 14:37:04 +00:00
cli_v2: implement LaunchRepairOperation and remove old stuff
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
f914db057a
lx added 1 commit 2025-02-05 18:37:59 +00:00
massively speed up compilation of garage_api_admin by not using async_trait
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
7c8fc04b96
lx changed title from WIP: Admin API refactoring: convert existing commands to API requests (step 3) to Admin API refactoring: convert existing commands to API requests (step 3) 2025-02-05 19:54:34 +00:00
lx merged commit 71655c1e89 into next-v2 2025-02-05 19:54:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#945
No description provided.
Delete branch "refactor-admin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?