Deuxfleurs/garage
34
65
Fork 83
Code Issues 95 Pull requests 16 Releases 32 Wiki Activity

support for multiple admin API token #982

Merged
lx merged 12 commits from multi-admin-token into next-v2 2025-03-12 09:30:20 +00:00
Conversation 0 Commits 12 Files changed 25 +1454 -141
lx commented 2025-03-11 12:10:25 +00:00
Owner
Copy link

Fix #944

  • Model for admin API token
  • Use model to check API access
  • Add configuration options to require tokens from the api token table without specifying a global token in the config
  • Admin API calls to manage api tokens
  • CLI to manage api tokens
  • openapi spec
  • Proof-reading
  • Testing
Fix #944 - [x] Model for admin API token - [x] Use model to check API access - [x] Add configuration options to require tokens from the api token table without specifying a global token in the config - [x] Admin API calls to manage api tokens - [x] CLI to manage api tokens - [x] openapi spec - [x] Proof-reading - [x] Testing
lx added 2 commits 2025-03-11 12:10:25 +00:00
add model for admin key table
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
6e19c6b446
lx force-pushed multi-admin-token from 6e19c6b446 to 56f2cd180d 2025-03-11 12:11:24 +00:00 Compare
lx force-pushed multi-admin-token from 56f2cd180d to 64cebc63d7 2025-03-11 12:40:44 +00:00 Compare
lx added this to the v2.0 milestone 2025-03-11 12:40:54 +00:00
lx changed title from WIP: support for multiple admin API tokens to WIP: support for multiple admin API keys 2025-03-11 12:43:13 +00:00
lx changed title from WIP: support for multiple admin API keys to WIP: support for multiple admin API token 2025-03-11 12:43:49 +00:00
lx force-pushed multi-admin-token from 64cebc63d7 to 18461d3567 2025-03-11 12:50:09 +00:00 Compare
lx force-pushed multi-admin-token from 18461d3567 to 004eb94e14 2025-03-11 12:51:24 +00:00 Compare
lx added 1 commit 2025-03-11 13:15:26 +00:00
admin api: add metrics_require_token config option and update doc
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
e1fe77997a
lx force-pushed multi-admin-token from e1fe77997a to ea93d56c96 2025-03-11 13:16:27 +00:00 Compare
lx force-pushed multi-admin-token from ea93d56c96 to ff6ec62d54 2025-03-11 13:17:26 +00:00 Compare
lx added 1 commit 2025-03-11 14:17:41 +00:00
admin api: add functions to manage admin api tokens
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
d067a40b3f
lx added 1 commit 2025-03-11 14:38:58 +00:00
admin api: add openapi spec for admin token management functions
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
9511b20153
lx added 1 commit 2025-03-11 14:57:44 +00:00
admin api: mention admin_token and metrics_token in ListAdminTokensResponse
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
ec0da3b644
lx added 1 commit 2025-03-11 17:09:36 +00:00
cli: add functions to manage admin api tokens
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
1bd7689301
lx added 1 commit 2025-03-11 17:21:09 +00:00
admin api: specify date-time format in openapi spec
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
ae9a9727f1
lx force-pushed multi-admin-token from ae9a9727f1 to 22c0420607 2025-03-11 17:25:57 +00:00 Compare
lx added 1 commit 2025-03-12 08:22:07 +00:00
move bucket search logic from helper to admin api
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
eb40475f1e
lx added 1 commit 2025-03-12 08:30:43 +00:00
admin_token_table: implement is_tombstone()
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
325f79012c
lx added 1 commit 2025-03-12 08:52:48 +00:00
add creation date to admin api tokens
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
3df75eadd2
lx force-pushed multi-admin-token from 3df75eadd2 to 88b4623bf1 2025-03-12 08:57:39 +00:00 Compare
lx added 1 commit 2025-03-12 09:15:35 +00:00
cli: add and remove scopes using --scope=+Scope or --scope=-Scope
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
ccaff8c250
lx force-pushed multi-admin-token from ccaff8c250 to d2a064bb1b 2025-03-12 09:20:18 +00:00 Compare
lx changed title from WIP: support for multiple admin API token to support for multiple admin API token 2025-03-12 09:30:14 +00:00
lx merged commit fd2472d488 into next-v2 2025-03-12 09:30:20 +00:00
lx deleted branch multi-admin-token 2025-03-12 09:30:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind/experimental

PRs implementing experimental features / features used only for debugging

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
admin-sdk
Related to the admin SDKs that provide API bindings for various languages

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind/experimental
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
admin-sdk
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
v2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#982
No description provided.
Delete branch "multi-admin-token"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?