src/db/lmdb_adapter.rs

@@ -10,9 +10,7 @@ use std::sync::{Arc, RwLock};
 use heed::types::ByteSlice;
 use heed::{BytesDecode, Env, RoTxn, RwTxn, UntypedDatabase as Database};
 
-use crate::{
+use crate::{Db, Error, IDb, ITx, ITxFn, Result, TxError, TxFnResult, TxResult, Value, ValueIter};
-	Db, Error, IDb, ITx, ITxFn, Result, TxError, TxFnResult, TxResult, Value, ValueIter,
-};
 
 pub use heed;
 

src/db/sled_adapter.rs

@@ -9,9 +9,7 @@ use sled::transaction::{
 	UnabortableTransactionError,
 };
 
-use crate::{
+use crate::{Db, Error, IDb, ITx, ITxFn, Result, TxError, TxFnResult, TxResult, Value, ValueIter};
-	Db, Error, IDb, ITx, ITxFn, Result, TxError, TxFnResult, TxResult, Value, ValueIter,
-};
 
 pub use sled;
 

src/garage/repair.rs

@@ -67,13 +67,12 @@ impl Repair {
 		let mut i = 0;
 
 		while !*must_exit.borrow() {
-			let item_bytes = {
+			let item_bytes = match self.garage.version_table.data.store.get_gt(pos)? {
-				let (k, v) = match self.garage.version_table.data.store.get_gt(pos)? {
+				Some((k, v)) => {
-					Some(pair) => pair,
-					None => break,
-				};
 					pos = k;
 					v
+				}
+				None => break,
 			};
 
 			i += 1;
@@ -119,13 +118,12 @@ impl Repair {
 		let mut i = 0;
 
 		while !*must_exit.borrow() {
-			let item_bytes = {
+			let item_bytes = match self.garage.block_ref_table.data.store.get_gt(pos)? {
-				let (k, v) = match self.garage.block_ref_table.data.store.get_gt(pos)? {
+				Some((k, v)) => {
-					Some(pair) => pair,
-					None => break,
-				};
 					pos = k;
 					v
+				}
+				None => break,
 			};
 
 			i += 1;

src/table/data.rs

@@ -243,10 +243,7 @@ where
 
 	pub(crate) fn delete_if_equal(self: &Arc<Self>, k: &[u8], v: &[u8]) -> Result<bool, Error> {
 		let removed = self.store.db().transaction(|mut tx| {
-			let remove = match tx.get(&self.store, k)? {
+			let remove = matches!(tx.get(&self.store, k)?, Some(cur_v) if cur_v == v => true);
-				Some(cur_v) if cur_v == v => true,
-				_ => false,
-			};
 			if remove {
 				tx.remove(&self.store, k)?;
 				tx.insert(&self.merkle_todo, k, vec![])?;

src/table/gc.rs

@@ -383,10 +383,8 @@ impl GcTodoEntry {
 	pub(crate) fn remove_if_equal(&self, gc_todo_tree: &db::Tree) -> Result<(), Error> {
 		let key = self.todo_table_key();
 		gc_todo_tree.db().transaction(|mut tx| {
-			let remove = match tx.get(gc_todo_tree, &key)? {
+			let remove =
-				Some(ov) if ov == self.value_hash.as_slice() => true,
+				matches!(tx.get(gc_todo_tree, &key)? Some(ov) if ov == self.value_hash.as_slice());
-				_ => false,
-			};
 			if remove {
 				tx.remove(gc_todo_tree, &key)?;
 			}

src/table/merkle.rs

@@ -140,10 +140,7 @@ where
 			.transaction(|mut tx| self.update_item_rec(&mut tx, k, &khash, &key, new_vhash))?;
 
 		let deleted = self.data.merkle_todo.db().transaction(|mut tx| {
-			let remove = match tx.get(&self.data.merkle_todo, k)? {
+			let remove = matches!(tx.get(&self.data.merkle_todo, k)?, Some(ov) if ov == vhash_by);
-				Some(ov) if ov == vhash_by => true,
-				_ => false,
-			};
 			if remove {
 				tx.remove(&self.data.merkle_todo, k)?;
 			}