Deuxfleurs/garage
32
58
Fork 80
Code Issues 100 Pull requests 18 Releases 30 Wiki Activity

Use content defined chunking #43

Merged
lx merged 4 commits from trinity-1686a/garage:content-defined-chunking into main 2021-04-06 20:18:46 +00:00
Conversation 3 Commits 4 Files changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6cbc8d6ec9 - Show all commits

2
src/api/s3_put.rs
View file

@ -313,7 +313,7 @@ impl BodyChunker {
let block = self.buf.drain(..length).collect::<Vec<u8>>(); let block = self.buf.drain(..length).collect::<Vec<u8>>();
Ok(Some(block)) Ok(Some(block))
} else { } else {
Ok(None) unreachable!("FastCDC returned not chunk")
lx commented 2021-04-06 13:56:54 +00:00
Outdated
Review
Copy link

I think that if FastCDC is giving us None here then it's a bug and we should throw an error. We can probably just put unreachable!() here.

I think that if FastCDC is giving us `None` here then it's a bug and we should throw an error. We can probably just put `unreachable!()` here.
} }
} }
} }