Deuxfleurs/garage
44
56
Fork 74
Code Issues 100 Pull requests 14 Releases 30 Wiki Activity

Support website publishing #7

Merged
lx merged 61 commits from feature/website into master 2021-01-15 16:49:51 +00:00
Conversation 3 Commits 61 Files changed 17 +1 -3
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f496e41ef4 - Show all commits

4
src/garage/admin_rpc.rs
View file

@ -175,9 +175,7 @@ impl AdminRpcHandler {
Ok(AdminRPC::Ok(msg.to_string())) Ok(AdminRPC::Ok(msg.to_string()))
} else { } else {
quentin marked this conversation as resolved
lx commented 2021-01-13 21:07:30 +00:00
Review
Copy link

Probably put unreachable!() in else branch ? Because get_existing_bucket does not return a bucket that is deleted. (I think so, this should be checked)

Probably put `unreachable!()` in else branch ? Because get_existing_bucket does not return a bucket that is deleted. (I think so, this should be checked)
quentin commented 2021-01-15 14:29:06 +00:00
Review
Copy link

Checked.
Indeed, it does not return deleted buckets.

        async fn get_existing_bucket(&self, bucket: &String) -> Result<Bucket, Error> {
                self.garage
                        .bucket_table
                        .get(&EmptyKey, bucket)
                        .await?
                        .filter(|b| !b.is_deleted())
                        .map(Ok)
                        .unwrap_or(Err(Error::BadRPC(format!(
                                "Bucket {} does not exist",
                                bucket
                        ))))
        }
Checked. Indeed, it does not return deleted buckets. ```rust async fn get_existing_bucket(&self, bucket: &String) -> Result<Bucket, Error> { self.garage .bucket_table .get(&EmptyKey, bucket) .await? .filter(|b| !b.is_deleted()) .map(Ok) .unwrap_or(Err(Error::BadRPC(format!( "Bucket {} does not exist", bucket )))) } ```
return Err(Error::Message(format!( unreachable!();
"Bucket is deleted in update_bucket_key"
)));
} }
quentin marked this conversation as resolved
lx commented 2021-01-13 21:05:02 +00:00
Review
Copy link

update_bucket_key ?

`update_bucket_key` ?
} }
} }