Deuxfleurs/garage
45
52
Fork 68
Code Issues 92 Pull requests 10 Releases 30 Wiki Activity

WIP: add metrics to the metadata engine #853

Draft
quentin wants to merge 8 commits from feat-metrics-metadata-engine into main
pull from: feat-metrics-metadata-engine
merge into: Deuxfleurs:main
Conversation 0 Commits 8 Files changed 9 +5 -11
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 14163b5853 - Show all commits

16
src/db/metric_proxy.rs
View file

@ -16,8 +16,7 @@ use opentelemetry::{
pub struct MetricDbProxy { pub struct MetricDbProxy {
//@FIXME Replace with a template //@FIXME Replace with a template
db: LmdbDb, db: LmdbDb,
op_counter: Counter<u64>, op: ValueRecorder<f64>,
op_duration: ValueRecorder<f64>,
} }
impl MetricDbProxy { impl MetricDbProxy {
@ -25,13 +24,9 @@ impl MetricDbProxy {
let meter = global::meter("garage/web"); let meter = global::meter("garage/web");
let s = Self { let s = Self {
db, db,
op_counter: meter op: meter
.u64_counter("db.op_counter") .f64_value_recorder("db.op")
.with_description("Number of operations on the local metadata engine") .with_description("Duration and amount of operations on the local metadata engine")
.init(),
op_duration: meter
.f64_value_recorder("db.op_duration")
.with_description("Duration of operations on the local metadata engine")
.with_unit(Unit::new("ms")) .with_unit(Unit::new("ms"))
.init(), .init(),
}; };
@ -50,7 +45,6 @@ impl MetricDbProxy {
KeyValue::new("cat", cat), KeyValue::new("cat", cat),
KeyValue::new("tx", tx), KeyValue::new("tx", tx),
]; ];
self.op_counter.add(1, &metric_tags);
let request_start = Instant::now(); let request_start = Instant::now();
let res = fx(); let res = fx();
@ -58,7 +52,7 @@ impl MetricDbProxy {
.saturating_duration_since(request_start) .saturating_duration_since(request_start)
.as_nanos(); .as_nanos();
let delay_millis: f64 = delay_nanos as f64 / 1_000_000f64; let delay_millis: f64 = delay_nanos as f64 / 1_000_000f64;
self.op_duration.record(delay_millis, &metric_tags); self.op.record(delay_millis, &metric_tags);
res res
} }