Deuxfleurs/garage
45
52
Fork 68
Code Issues 92 Pull requests 10 Releases 30 Wiki Activity

WIP: add metrics to the metadata engine #853

Draft
quentin wants to merge 8 commits from feat-metrics-metadata-engine into main
pull from: feat-metrics-metadata-engine
merge into: Deuxfleurs:main
Conversation 0 Commits 8 Files changed 9 +8 -7
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 1685d83c04 - Show all commits

13
src/db/metric_proxy.rs
View file

@ -9,7 +9,7 @@ use crate::{
}; };
use opentelemetry::{ use opentelemetry::{
global, global,
metrics::{Counter, ValueRecorder}, metrics::{Counter, Unit, ValueRecorder},
KeyValue, KeyValue,
}; };
@ -32,6 +32,7 @@ impl MetricDbProxy {
op_duration: meter op_duration: meter
.f64_value_recorder("db.op_duration") .f64_value_recorder("db.op_duration")
.with_description("Duration of operations on the local metadata engine") .with_description("Duration of operations on the local metadata engine")
.with_unit(Unit::new("us"))
.init(), .init(),
}; };
Db(Arc::new(s)) Db(Arc::new(s))
@ -53,12 +54,12 @@ impl MetricDbProxy {
let request_start = Instant::now(); let request_start = Instant::now();
let res = fx(); let res = fx();
self.op_duration.record( let delay_nanos = Instant::now()
Instant::now()
.saturating_duration_since(request_start) .saturating_duration_since(request_start)
.as_secs_f64(), .as_nanos();
&metric_tags, let delay_micro: f64 = delay_nanos as f64 / 1000.0f64;
); println!("delay {}", delay_micro);
self.op_duration.record(delay_micro, &metric_tags);
res res
} }