Alex
b44d3fc796
All checks were successful
continuous-integration/drone/push Build is passing
- [x] Design interface - [x] Implement Sled backend - [x] Re-implement the SledCountedTree hack ~~on Sled backend~~ on all backends (i.e. over the abstraction) - [x] Convert Garage code to use generic interface - [x] Proof-read converted Garage code - [ ] Test everything well - [x] Implement sqlite backend - [x] Implement LMDB backend - [ ] (Implement Persy backend?) - [ ] (Implement other backends? (like RocksDB, ...)) - [x] Implement backend choice in config file and garage server module - [x] Add CLI for converting between DB formats - Exploit the new interface to put more things in transactions - [x] `.updated()` trigger on Garage tables Fix #284 **Bugs** - [x] When exporting sqlite, trees iterate empty?? - [x] LMDB doesn't work **Known issues for various back-ends** - Sled: - Eats all my RAM and also all my disk space - `.len()` has to traverse the whole table - Is actually quite slow on some operations - And is actually pretty bad code... - Sqlite: - Requires a lock to be taken on all operations. The lock is also taken when iterating on a table with `.iter()`, and the lock isn't released until the iterator is dropped. This means that we must be VERY carefull to not do anything else inside a `.iter()` loop or else we will have a deadlock! Most such cases have been eliminated from the Garage codebase, but there might still be some that remain. If your Garage-over-Sqlite seems to hang/freeze, this is the reason. - (adapter uses a bunch of unsafe code) - Heed (LMDB): - Not suited for 32-bit machines as it has to map the whole DB in memory. - (adpater uses a tiny bit of unsafe code) **My recommendation:** avoid 32-bit machines and use LMDB as much as possible. **Converting databases** is actually quite easy. For example from Sled to LMDB: ```bash cd src/db cargo run --features cli --bin convert -- -i path/to/garage/meta/db -a sled -o path/to/garage/meta/db.lmdb -b lmdb ``` Then, just add this to your `config.toml`: ```toml db_engine = "lmdb" ``` Co-authored-by: Alex Auvolat <alex@adnab.me> Reviewed-on: #322 Co-authored-by: Alex <alex@adnab.me> Co-committed-by: Alex <alex@adnab.me>
86 lines
1.7 KiB
Rust
86 lines
1.7 KiB
Rust
use crate::common;
|
|
use aws_sdk_s3::model::BucketLocationConstraint;
|
|
use aws_sdk_s3::output::DeleteBucketOutput;
|
|
|
|
#[tokio::test]
|
|
async fn test_bucket_all() {
|
|
let ctx = common::context();
|
|
let bucket_name = "hello";
|
|
|
|
{
|
|
// Create bucket
|
|
//@TODO check with an invalid bucket name + with an already existing bucket
|
|
let r = ctx
|
|
.client
|
|
.create_bucket()
|
|
.bucket(bucket_name)
|
|
.send()
|
|
.await
|
|
.unwrap();
|
|
|
|
assert_eq!(r.location.unwrap(), "/hello");
|
|
}
|
|
{
|
|
// List buckets
|
|
let r = ctx.client.list_buckets().send().await.unwrap();
|
|
assert!(r
|
|
.buckets
|
|
.as_ref()
|
|
.unwrap()
|
|
.iter()
|
|
.filter(|x| x.name.as_ref().is_some())
|
|
.any(|x| x.name.as_ref().unwrap() == "hello"));
|
|
}
|
|
{
|
|
// Get its location
|
|
let r = ctx
|
|
.client
|
|
.get_bucket_location()
|
|
.bucket(bucket_name)
|
|
.send()
|
|
.await
|
|
.unwrap();
|
|
|
|
match r.location_constraint.unwrap() {
|
|
BucketLocationConstraint::Unknown(v) if v.as_str() == "garage-integ-test" => (),
|
|
_ => unreachable!("wrong region"),
|
|
}
|
|
}
|
|
{
|
|
// (Stub) check GetVersioning
|
|
let r = ctx
|
|
.client
|
|
.get_bucket_versioning()
|
|
.bucket(bucket_name)
|
|
.send()
|
|
.await
|
|
.unwrap();
|
|
|
|
assert!(r.status.is_none());
|
|
}
|
|
{
|
|
// Delete bucket
|
|
// @TODO add a check with a non-empty bucket and check failure
|
|
let r = ctx
|
|
.client
|
|
.delete_bucket()
|
|
.bucket(bucket_name)
|
|
.send()
|
|
.await
|
|
.unwrap();
|
|
|
|
assert_eq!(r, DeleteBucketOutput::builder().build());
|
|
}
|
|
{
|
|
// Check bucket is deleted with List buckets
|
|
let r = ctx.client.list_buckets().send().await.unwrap();
|
|
assert!(!r
|
|
.buckets
|
|
.as_ref()
|
|
.unwrap()
|
|
.iter()
|
|
.filter(|x| x.name.as_ref().is_some())
|
|
.any(|x| x.name.as_ref().unwrap() == "hello"));
|
|
}
|
|
}
|