Alex
b44d3fc796
All checks were successful
continuous-integration/drone/push Build is passing
- [x] Design interface - [x] Implement Sled backend - [x] Re-implement the SledCountedTree hack ~~on Sled backend~~ on all backends (i.e. over the abstraction) - [x] Convert Garage code to use generic interface - [x] Proof-read converted Garage code - [ ] Test everything well - [x] Implement sqlite backend - [x] Implement LMDB backend - [ ] (Implement Persy backend?) - [ ] (Implement other backends? (like RocksDB, ...)) - [x] Implement backend choice in config file and garage server module - [x] Add CLI for converting between DB formats - Exploit the new interface to put more things in transactions - [x] `.updated()` trigger on Garage tables Fix #284 **Bugs** - [x] When exporting sqlite, trees iterate empty?? - [x] LMDB doesn't work **Known issues for various back-ends** - Sled: - Eats all my RAM and also all my disk space - `.len()` has to traverse the whole table - Is actually quite slow on some operations - And is actually pretty bad code... - Sqlite: - Requires a lock to be taken on all operations. The lock is also taken when iterating on a table with `.iter()`, and the lock isn't released until the iterator is dropped. This means that we must be VERY carefull to not do anything else inside a `.iter()` loop or else we will have a deadlock! Most such cases have been eliminated from the Garage codebase, but there might still be some that remain. If your Garage-over-Sqlite seems to hang/freeze, this is the reason. - (adapter uses a bunch of unsafe code) - Heed (LMDB): - Not suited for 32-bit machines as it has to map the whole DB in memory. - (adpater uses a tiny bit of unsafe code) **My recommendation:** avoid 32-bit machines and use LMDB as much as possible. **Converting databases** is actually quite easy. For example from Sled to LMDB: ```bash cd src/db cargo run --features cli --bin convert -- -i path/to/garage/meta/db -a sled -o path/to/garage/meta/db.lmdb -b lmdb ``` Then, just add this to your `config.toml`: ```toml db_engine = "lmdb" ``` Co-authored-by: Alex Auvolat <alex@adnab.me> Reviewed-on: #322 Co-authored-by: Alex <alex@adnab.me> Co-committed-by: Alex <alex@adnab.me>
78 lines
1.7 KiB
Rust
78 lines
1.7 KiB
Rust
use serde::{Deserialize, Serialize};
|
|
use std::sync::Arc;
|
|
|
|
use garage_db as db;
|
|
|
|
use garage_util::data::*;
|
|
|
|
use garage_table::crdt::Crdt;
|
|
use garage_table::*;
|
|
|
|
use garage_block::manager::*;
|
|
|
|
#[derive(PartialEq, Clone, Debug, Serialize, Deserialize)]
|
|
pub struct BlockRef {
|
|
/// Hash (blake2 sum) of the block, used as partition key
|
|
pub block: Hash,
|
|
|
|
/// Id of the Version for the object containing this block, used as sorting key
|
|
pub version: Uuid,
|
|
|
|
// Keep track of deleted status
|
|
/// Is the Version that contains this block deleted
|
|
pub deleted: crdt::Bool,
|
|
}
|
|
|
|
impl Entry<Hash, Uuid> for BlockRef {
|
|
fn partition_key(&self) -> &Hash {
|
|
&self.block
|
|
}
|
|
fn sort_key(&self) -> &Uuid {
|
|
&self.version
|
|
}
|
|
fn is_tombstone(&self) -> bool {
|
|
self.deleted.get()
|
|
}
|
|
}
|
|
|
|
impl Crdt for BlockRef {
|
|
fn merge(&mut self, other: &Self) {
|
|
self.deleted.merge(&other.deleted);
|
|
}
|
|
}
|
|
|
|
pub struct BlockRefTable {
|
|
pub block_manager: Arc<BlockManager>,
|
|
}
|
|
|
|
impl TableSchema for BlockRefTable {
|
|
const TABLE_NAME: &'static str = "block_ref";
|
|
|
|
type P = Hash;
|
|
type S = Uuid;
|
|
type E = BlockRef;
|
|
type Filter = DeletedFilter;
|
|
|
|
fn updated(
|
|
&self,
|
|
tx: &mut db::Transaction,
|
|
old: Option<&Self::E>,
|
|
new: Option<&Self::E>,
|
|
) -> db::TxOpResult<()> {
|
|
let block = old.or(new).unwrap().block;
|
|
let was_before = old.map(|x| !x.deleted.get()).unwrap_or(false);
|
|
let is_after = new.map(|x| !x.deleted.get()).unwrap_or(false);
|
|
if is_after && !was_before {
|
|
self.block_manager.block_incref(tx, block)?;
|
|
}
|
|
if was_before && !is_after {
|
|
self.block_manager.block_decref(tx, block)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
fn matches_filter(entry: &Self::E, filter: &Self::Filter) -> bool {
|
|
filter.apply(entry.deleted.get())
|
|
}
|
|
}
|