Alex
b44d3fc796
All checks were successful
continuous-integration/drone/push Build is passing
- [x] Design interface - [x] Implement Sled backend - [x] Re-implement the SledCountedTree hack ~~on Sled backend~~ on all backends (i.e. over the abstraction) - [x] Convert Garage code to use generic interface - [x] Proof-read converted Garage code - [ ] Test everything well - [x] Implement sqlite backend - [x] Implement LMDB backend - [ ] (Implement Persy backend?) - [ ] (Implement other backends? (like RocksDB, ...)) - [x] Implement backend choice in config file and garage server module - [x] Add CLI for converting between DB formats - Exploit the new interface to put more things in transactions - [x] `.updated()` trigger on Garage tables Fix #284 **Bugs** - [x] When exporting sqlite, trees iterate empty?? - [x] LMDB doesn't work **Known issues for various back-ends** - Sled: - Eats all my RAM and also all my disk space - `.len()` has to traverse the whole table - Is actually quite slow on some operations - And is actually pretty bad code... - Sqlite: - Requires a lock to be taken on all operations. The lock is also taken when iterating on a table with `.iter()`, and the lock isn't released until the iterator is dropped. This means that we must be VERY carefull to not do anything else inside a `.iter()` loop or else we will have a deadlock! Most such cases have been eliminated from the Garage codebase, but there might still be some that remain. If your Garage-over-Sqlite seems to hang/freeze, this is the reason. - (adapter uses a bunch of unsafe code) - Heed (LMDB): - Not suited for 32-bit machines as it has to map the whole DB in memory. - (adpater uses a tiny bit of unsafe code) **My recommendation:** avoid 32-bit machines and use LMDB as much as possible. **Converting databases** is actually quite easy. For example from Sled to LMDB: ```bash cd src/db cargo run --features cli --bin convert -- -i path/to/garage/meta/db -a sled -o path/to/garage/meta/db.lmdb -b lmdb ``` Then, just add this to your `config.toml`: ```toml db_engine = "lmdb" ``` Co-authored-by: Alex Auvolat <alex@adnab.me> Reviewed-on: #322 Co-authored-by: Alex <alex@adnab.me> Co-committed-by: Alex <alex@adnab.me>
108 lines
2.4 KiB
Rust
108 lines
2.4 KiB
Rust
use std::sync::Arc;
|
|
|
|
use garage_util::crdt::*;
|
|
use garage_util::data::*;
|
|
use garage_util::error::Error as GarageError;
|
|
use garage_util::time::*;
|
|
|
|
use garage_model_050::bucket_table as old_bucket;
|
|
|
|
use crate::bucket_alias_table::*;
|
|
use crate::bucket_table::*;
|
|
use crate::garage::Garage;
|
|
use crate::helper::error::*;
|
|
use crate::permission::*;
|
|
|
|
pub struct Migrate {
|
|
pub garage: Arc<Garage>,
|
|
}
|
|
|
|
impl Migrate {
|
|
pub async fn migrate_buckets050(&self) -> Result<(), Error> {
|
|
let tree = self
|
|
.garage
|
|
.db
|
|
.open_tree("bucket:table")
|
|
.map_err(GarageError::from)?;
|
|
|
|
let mut old_buckets = vec![];
|
|
for res in tree.iter().map_err(GarageError::from)? {
|
|
let (_k, v) = res.map_err(GarageError::from)?;
|
|
let bucket = rmp_serde::decode::from_read_ref::<_, old_bucket::Bucket>(&v[..])
|
|
.map_err(GarageError::from)?;
|
|
old_buckets.push(bucket);
|
|
}
|
|
|
|
for bucket in old_buckets {
|
|
if let old_bucket::BucketState::Present(p) = bucket.state.get() {
|
|
self.migrate_buckets050_do_bucket(&bucket, p).await?;
|
|
}
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub async fn migrate_buckets050_do_bucket(
|
|
&self,
|
|
old_bucket: &old_bucket::Bucket,
|
|
old_bucket_p: &old_bucket::BucketParams,
|
|
) -> Result<(), Error> {
|
|
let bucket_id = blake2sum(old_bucket.name.as_bytes());
|
|
|
|
let new_name = if is_valid_bucket_name(&old_bucket.name) {
|
|
old_bucket.name.clone()
|
|
} else {
|
|
// if old bucket name was not valid, replace it by
|
|
// a hex-encoded name derived from its identifier
|
|
hex::encode(&bucket_id.as_slice()[..16])
|
|
};
|
|
|
|
let website = if *old_bucket_p.website.get() {
|
|
Some(WebsiteConfig {
|
|
index_document: "index.html".into(),
|
|
error_document: None,
|
|
})
|
|
} else {
|
|
None
|
|
};
|
|
|
|
self.garage
|
|
.bucket_table
|
|
.insert(&Bucket {
|
|
id: bucket_id,
|
|
state: Deletable::Present(BucketParams {
|
|
creation_date: now_msec(),
|
|
authorized_keys: Map::new(),
|
|
aliases: LwwMap::new(),
|
|
local_aliases: LwwMap::new(),
|
|
website_config: Lww::new(website),
|
|
cors_config: Lww::new(None),
|
|
}),
|
|
})
|
|
.await?;
|
|
|
|
self.garage
|
|
.bucket_helper()
|
|
.set_global_bucket_alias(bucket_id, &new_name)
|
|
.await?;
|
|
|
|
for (k, ts, perm) in old_bucket_p.authorized_keys.items().iter() {
|
|
self.garage
|
|
.bucket_helper()
|
|
.set_bucket_key_permissions(
|
|
bucket_id,
|
|
k,
|
|
BucketKeyPerm {
|
|
timestamp: *ts,
|
|
allow_read: perm.allow_read,
|
|
allow_write: perm.allow_write,
|
|
allow_owner: false,
|
|
},
|
|
)
|
|
.await?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
}
|