Deuxfleurs/garagehq.deuxfleurs.fr
26
2
Fork 1
Code Issues 5 Pull requests 3 Projects Releases Wiki Activity

Web app manifest improvements #18

Merged
lx merged 2 commits from tixie/garagehq.deuxfleurs.fr:webappmanifest-improvements into master 2024-04-08 15:06:20 +00:00
Conversation 1 Commits 2 Files changed 1 +3 -3
tixie commented 2024-04-08 14:10:34 +00:00
Owner
Copy link

This PR bring some little improvements to the web app manifest:

  1. Add values to name and short_name keys
  2. Change display value from standalone to browser to avoid the website from being displayed in fullscreen, without the web browser controls (no backward, forward,reload buttons) when installed as a PWA.
    The standalone mode is adapted for SinglePageApplications, fully working on client side and have the entire navigation experience re-implemented in them.
    This is not the case of Garage homepage and documentation. Using the default value (browser) will change the behavior into making the app icon open the website in the user's default browser (so into the web navigation experience they're used to).

Resources on the "display" modes:

This PR bring some little improvements to the [web app manifest](https://w3c.github.io/manifest/): 1. Add values to `name` and `short_name` keys 2. Change display value from `standalone` to `browser` to avoid the website from being displayed in fullscreen, without the web browser controls (no backward, forward,reload buttons) when installed as a PWA. The standalone mode is adapted for [SinglePageApplications](https://developer.mozilla.org/en-US/docs/Glossary/SPA), fully working on client side and have the entire navigation experience re-implemented in them. This is not the case of Garage homepage and documentation. Using the default value (`browser`) will change the behavior into making the app icon open the website in the user's default browser (so into the web navigation experience they're used to). Resources on the "display" modes: - https://developer.mozilla.org/en-US/docs/Web/Manifest/display - https://web.dev/learn/pwa/app-design#display_modes
lx was assigned by tixie 2024-04-08 14:10:34 +00:00
tixie added 2 commits 2024-04-08 14:10:34 +00:00
tixie requested review from lx 2024-04-08 14:14:42 +00:00
lx was unassigned by tixie 2024-04-08 14:14:51 +00:00
tixie self-assigned this 2024-04-08 14:15:03 +00:00
lx commented 2024-04-08 15:06:16 +00:00
Owner
Copy link

Thanks :)

Thanks :)
lx merged commit 93273a8181 into master 2024-04-08 15:06:20 +00:00
tixie deleted branch webappmanifest-improvements 2024-04-08 15:30:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
tixie
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garagehq.deuxfleurs.fr#18
No description provided.
Delete branch "tixie/garagehq.deuxfleurs.fr:webappmanifest-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?