show everyone in the directory page by default #12

Merged
lx merged 1 commit from show-everyone-by-default into main 2021-08-18 12:14:50 +00:00
Owner

The current directory system is composed with a route (POST /directory/search) that returns an HTML document corresponding to the search results which is then embedded in the directory page on each search.

A popular request (issue #11) was to change this system to show all users in the public directory by default. Two solutions were found :

  1. Allow "wildcard" search when search box is empty and invoke it when the page is shown, so that the whole directory is embedded on page loaded.

  2. Change the template to embed the whole directory on the backend side before serving the page. This would require some major refactor.

Option 1. was developed in this PR but I can change the code if a better idea is found :)

The current directory system is composed with a route (POST /directory/search) that returns an HTML document corresponding to the search results which is then embedded in the directory page on each search. A popular request (issue #11) was to change this system to show all users in the public directory by default. Two solutions were found : 1. Allow "wildcard" search when search box is empty and invoke it when the page is shown, so that the whole directory is embedded on page loaded. 2. Change the template to embed the whole directory on the backend side before serving the page. This would require some major refactor. Option 1. was developed in this PR but I can change the code if a better idea is found :)
darkgallium added 1 commit 2021-08-18 11:38:27 +00:00
show everyone in the directory page by default
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
59c29e9c76
Owner

LGTM

Solves #11

LGTM Solves #11
lx merged commit 59c29e9c76 into main 2021-08-18 12:14:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/guichet#12
No description provided.