WIP: feat/UnderlignedTitle closes #18 #33

Draft

adrian wants to merge 6 commits from adrian/site:feat/UnderlignedTitle into feat/a11y

adrian commented

2024-02-15 12:03:51 +00:00

First-time contributor

No description provided.

adrian added 5 commits 2024-02-15 12:03:52 +00:00

added .idea to gitignore b7548e0447

fix: added unligned titles directly in html instead of :after :before in the css #18 1508aa1da3

fix: added :before logic with void content 5cabfd269c

fix: added aria hidden true to each underligned title #18 eab8c4824e

eol 8ffc2f3138

adrian requested review from adrien 2024-02-15 12:04:03 +00:00

adrian requested review from tixie 2024-02-15 12:04:03 +00:00

adrien commented

2024-02-15 14:47:53 +00:00

Owner

Not ok: All title IDs were replaced by classes. Title IDs have a utility as they allow to refer to a page section e.g. https://deuxfleurs.fr/#connaissance

The title edits otherwise look LGTM, but I need to ensure with a screen reader.

Not ok: All title IDs were replaced by classes. Title IDs have a utility as they allow to refer to a page section e.g. https://deuxfleurs.fr/#connaissance The title edits otherwise look LGTM, but I need to ensure with a screen reader.

adrien changed title from ~~feat/UnderlignedTitle closes #18~~ to WIP: feat/UnderlignedTitle closes #18

2024-02-15 14:55:13 +00:00

adrian added 1 commit 2024-02-18 08:55:44 +00:00

replaced class by id for title css #18 3f74ef0033

This pull request has changes conflicting with the target branch.

static/css/home.css
static/css/layout.css
static/index.html

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feat/UnderlignedTitle:adrian-feat/UnderlignedTitle

git checkout adrian-feat/UnderlignedTitle

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout feat/a11y

git merge --no-ff adrian-feat/UnderlignedTitle

git checkout adrian-feat/UnderlignedTitle

git rebase feat/a11y

git checkout feat/a11y

git merge --ff-only adrian-feat/UnderlignedTitle

git checkout adrian-feat/UnderlignedTitle

git rebase feat/a11y

git checkout feat/a11y

git merge --no-ff adrian-feat/UnderlignedTitle

git checkout feat/a11y

git merge --squash adrian-feat/UnderlignedTitle