Deuxfleurs
/
site
21
2
Fork 5
Code Issues 9 Pull Requests 6 Releases Wiki Activity

WIP: feat/UnderlignedTitle closes #18 #33

Draft
adrian wants to merge 6 commits from adrian/site:feat/UnderlignedTitle into feat/a11y
pull from: adrian/site:feat/UnderlignedTitle
merge into: Deuxfleurs:feat/a11y
Conversation 1 Commits 6 Files Changed 4 +405 -400
adrian commented 2024-02-15 12:03:51 +00:00
First-time contributor
Copy Link
No description provided.
adrian added 5 commits 2024-02-15 12:03:52 +00:00
adrian requested review from adrien 2024-02-15 12:04:03 +00:00
adrian requested review from tixie 2024-02-15 12:04:03 +00:00
adrien commented 2024-02-15 14:47:53 +00:00
Owner
Copy Link

Not ok: All title IDs were replaced by classes. Title IDs have a utility as they allow to refer to a page section e.g. https://deuxfleurs.fr/#connaissance

The title edits otherwise look LGTM, but I need to ensure with a screen reader.

Not ok: All title IDs were replaced by classes. Title IDs have a utility as they allow to refer to a page section e.g. https://deuxfleurs.fr/#connaissance The title edits otherwise look LGTM, but I need to ensure with a screen reader.
adrien changed title from feat/UnderlignedTitle closes #18 to WIP: feat/UnderlignedTitle closes #18 2024-02-15 14:55:13 +00:00
adrian added 1 commit 2024-02-18 08:55:44 +00:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b adrian-feat/UnderlignedTitle feat/a11y
git pull feat/UnderlignedTitle

Step 2:

Merge the changes and update on Forgejo.
git checkout feat/a11y
git merge --no-ff adrian-feat/UnderlignedTitle
git push origin feat/a11y
Sign in to join this conversation.
Reviewers
No reviewers
adrien
tixie
Labels
Clear labels   
cat
a11y
Accessibility issues

  
cat
compat
Compatibility

  
cat
content
Rédaction/Édition du contenu

  
cat
perf

  
part
calendar
La représentation ASCII Art des calendriers

No Label
cat
a11y
cat
compat
cat
content
cat
perf
part
calendar
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/site#33
No description provided.
Delete Branch "adrian/site:feat/UnderlignedTitle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?