Deuxfleurs/site

Fork 6

WIP: feat/PausePlayButton closes #16, #30 #34

Draft

adrian wants to merge 16 commits from adrian/site:feat/PausePlayButton into feat/a11y

adrian commented

2024-02-15 12:07:49 +00:00

First-time contributor

No description provided.

adrian added 12 commits 2024-02-15 12:07:49 +00:00

added .idea to gitignore b7548e0447

WIP pause the animation via button a396d36509

added pause/play button which pauses/plays the animations as a nav 06a73e6b10

feat: added prefered reduced motion (prm) condition which triggers to directly disable the animations if the prm equals to reduce #30 632986b36b

added aria region live attribute on each region which animates according to prefers-reduced-motion option selected #30 7c1b44bd29

feat: changed aria live attribute also if the prefers reduced motion is set to off and if the user clicks on the button to play/pause animations #30 14cfee2aee

fix: changed aria-orientation to undefined in the play/pause button 8cabd64acb

feat: button disappear when scrolling down #16 efeeba4743

improved performance of the script for the loading of it and the scroll event listener 013f315c50

added noindex for robots 0c3e79cd94

removed aria orientation of the nav 57eae6b835

removed sr-only class #16 63176f8e97

adrian requested review from adrien 2024-02-15 12:08:02 +00:00

adrian requested review from tixie 2024-02-15 12:08:02 +00:00

adrien commented

2024-02-15 14:15:19 +00:00

Owner

Not valid yet: prefers reduced motion totally forbids animation.
For some reason I have this setting on my system, so I'm screwed.

Working on a fix.

Not valid yet: `prefers reduced motion` totally forbids animation. For some reason I have this setting on my system, so I'm screwed. Working on a fix.

adrien added 1 commit 2024-02-15 14:33:46 +00:00

WIP : quelques corrections, et un début de booléen 'animationEnabled' qui doit déterminer si l'on anime ou pas la page, en s'y prenant au plus tôt : pas de code appelé si pas d'animation demandée, et arrêt auto de l'animation si on toggle le booléen d30acf4e37

adrien changed title from ~~feat/PausePlayButton closes #16, #30~~ to WIP: feat/PausePlayButton closes #16, #30

2024-02-15 14:46:25 +00:00

adrian added 1 commit 2024-02-19 08:37:11 +00:00

state triggering animations or not instead of checking the style of the buttons, ensuring code isn't call when prefers-reduced-motion is enabled #30 47a8f70c00

adrian added 1 commit 2024-02-19 08:48:46 +00:00

not displaying button when prefers-reduced-motion is set to reduce #30 489e7b9e4f

adrian added 1 commit 2024-02-19 12:36:17 +00:00

allowed users with reduced animations to resume animations #30 e5e9b9af79

This pull request has changes conflicting with the target branch.

static/css/layout.css
static/index.html
static/script-bon.js

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feat/PausePlayButton:adrian-feat/PausePlayButton

git checkout adrian-feat/PausePlayButton

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout feat/a11y

git merge --no-ff adrian-feat/PausePlayButton

git checkout adrian-feat/PausePlayButton

git rebase feat/a11y

git checkout feat/a11y

git merge --ff-only adrian-feat/PausePlayButton

git checkout adrian-feat/PausePlayButton

git rebase feat/a11y

git checkout feat/a11y

git merge --no-ff adrian-feat/PausePlayButton

git checkout feat/a11y

git merge --squash adrian-feat/PausePlayButton