Deuxfleurs/tricot
15
3
Fork 4
Code Issues 7 Pull requests 4 Projects Releases Wiki Activity

Add a counter of "in flight" requests in exported metrics #24

Closed
Armael wants to merge 0 commits from Armael/tricot:in_flight_meter into main
pull from: Armael/tricot:in_flight_meter
merge into: Deuxfleurs:main
Conversation 1 Commits - Files changed - +28 -3
Armael commented 2025-04-11 09:30:23 +00:00
Owner
Copy link
No description provided.
Armael added 3 commits 2025-04-11 09:30:24 +00:00 
The host tag is not currently included, but could be added later with
some refactorings if we need it.
quentin reviewed 2025-04-11 09:34:35 +00:00
src/https.rs
@ -44,3 +45,4 @@
request_proxy_duration: metrics::Histogram<f64>,
}
struct InFlightGuard<'a, 'b> {
quentin commented 2025-04-11 09:34:35 +00:00
Owner
Copy link

Maybe you can mention in a comment somewhere it's linked to Rust RAII pattern?
With some links like:

Could help a future contributor that is not familiar with this pattern ^^

Maybe you can mention in a comment somewhere it's linked to Rust RAII pattern? With some links like: - RAII guards: https://rust-unofficial.github.io/patterns/patterns/behavioural/RAII.html - RAII: https://doc.rust-lang.org/rust-by-example/scope/raii.html Could help a future contributor that is not familiar with this pattern ^^
requested review from quentin 2025-04-11 09:34:45 +00:00
quentin approved these changes 2025-04-11 10:04:32 +00:00
Armael commented 2025-04-11 10:16:26 +00:00
Author
Owner
Copy link

Forgejo is confused, merging manually.

Forgejo is confused, merging manually.
Armael closed this pull request 2025-04-11 10:16:26 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
quentin
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/tricot#24
No description provided.
Delete branch "Armael/tricot:in_flight_meter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?