Deuxfleurs/tricot
15
3
Fork 4
Code Issues 7 Pull requests 4 Projects Releases Wiki Activity

Add a log rate limiter #25

Closed
quentin wants to merge 0 commits from log-rate-limiter into main
pull from: log-rate-limiter
merge into: Deuxfleurs:main
Conversation 1 Commits - Files changed - +304 -34
quentin commented 2025-04-11 13:41:02 +00:00
Owner
Copy link

Features:

  • Apply only to info/debug/trace logs
  • Default to 1 log per second, can be changed with TRICOT_MAX_LOG_PER_SEC. For example TRICOT_MAX_LOG_PER_SEC=10 allows up to 10 log lines per second

Further work: governor seems to be a state of the art rate limiter for Rust. I think we could deploy it also on a per IPv4 and per-IPv6 prefix base to protect all our stacks. For example, we could allow only 10 req/sec per IP with some burst logic & so on & so forth

Features: - Apply only to info/debug/trace logs - Default to 1 log per second, can be changed with `TRICOT_MAX_LOG_PER_SEC`. For example `TRICOT_MAX_LOG_PER_SEC=10` allows up to 10 log lines per second Further work: governor seems to be a state of the art rate limiter for Rust. I think we could deploy it also on a per IPv4 and per-IPv6 prefix base to protect all our stacks. For example, we could allow only 10 req/sec per IP with some burst logic & so on & so forth
quentin added 1 commit 2025-04-11 13:41:03 +00:00
requested review from Armael 2025-04-11 13:41:08 +00:00
Armael reviewed 2025-04-11 14:19:41 +00:00
src/main.rs
@ -110,1 +113,4 @@
pub warmup_cert_memory_store: bool,
/// Drops some logs to avoid overloading the server.
/// Aapplies only to info/debugt/trace logs
Armael commented 2025-04-11 14:14:11 +00:00
Owner
Copy link

Aapplies -> applies

Aapplies -> applies
src/main.rs
@ -111,0 +116,4 @@
/// Aapplies only to info/debugt/trace logs
/// 100 = keep all logs
/// 50 = keep roughly half the logs
/// 0 = drop all logs
Armael commented 2025-04-11 14:15:29 +00:00
Owner
Copy link

the docstring seems inconsistent with what comes after (keep percentage vs quota per second)

the docstring seems inconsistent with what comes after (keep percentage vs quota per second)
src/main.rs
@ -111,0 +133,4 @@
governor::state::NotKeyed,
governor::state::InMemoryState,
governor::clock::QuantaClock,
>,
Armael commented 2025-04-11 14:17:00 +00:00
Owner
Copy link

is this not the same as DefaultDirectRateLimiter?

is this not the same as `DefaultDirectRateLimiter`?
Armael commented 2025-04-12 14:56:21 +00:00
Owner
Copy link

Manually merged to main.

Manually merged to main.
Armael closed this pull request 2025-04-12 14:56:22 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Armael
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/tricot#25
No description provided.
Delete branch "log-rate-limiter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?