Alex lx
1 follower · 0 following
Repositories
7
 Projects Packages Public activity Starred repositories
13
lx commented on pull request Deuxfleurs/garage#643 2023-10-04 08:49:17 +00:00
Add support for specifying rpc_secret_file, metrics_token_file and admin_token_file using environment variables

Reading the files specified in the _FILE environment variables will have to happen in fill_secrets. The return…

lx commented on pull request Deuxfleurs/garage#643 2023-10-04 08:47:49 +00:00
Add support for specifying rpc_secret_file, metrics_token_file and admin_token_file using environment variables

In the existing code, all environment variables used by the Garage CLI are declared in main.rs in the garage crate, here: <https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/garage…

lx pushed to next at Deuxfleurs/garage 2023-10-04 08:44:55 +00:00
920dec393a cli: more precise doc comment
lx pushed to main at Deuxfleurs/nixcfg 2023-10-04 08:44:24 +00:00
525f04515e staging: deploy garage v0.9.0-rc1
lx pushed to main at Deuxfleurs/nixcfg 2023-10-03 20:56:44 +00:00
2e3725e8a2 staging: disable jaeger; update diplonat
lx pushed tag v0.9.0-rc1 to Deuxfleurs/garage 2023-10-03 16:41:03 +00:00
lx pushed to next at Deuxfleurs/garage 2023-10-03 16:40:43 +00:00
2e656b541b Merge branch 'main' into next
1243db87f2 Merge pull request 'Add support for binding to unix domain sockets' (#640) from networkException/garage:unix-sockets into main
6f8a87814b doc: add documentation for specifying unix socket paths
7907a09acc api: allow custom unix bind mode and use 0o220 for admin server
16aa418e47 Merge pull request 'doc: update endpoint_url documentation' (#641) from flokli/garage:aws-endpoint-url into main
Compare 10 commits »
lx pushed to main at Deuxfleurs/garage 2023-10-03 16:23:03 +00:00
1243db87f2 Merge pull request 'Add support for binding to unix domain sockets' (#640) from networkException/garage:unix-sockets into main
6f8a87814b doc: add documentation for specifying unix socket paths
7907a09acc api: allow custom unix bind mode and use 0o220 for admin server
8ec6a53b35 everywhere: support unix sockets when binding in various places
7353038a64 config: allow using paths for unix domain sockets in various places
Compare 7 commits »
lx merged pull request Deuxfleurs/garage#640 2023-10-03 16:23:02 +00:00
Add support for binding to unix domain sockets
lx commented on pull request Deuxfleurs/garage#640 2023-10-03 16:22:58 +00:00
Add support for binding to unix domain sockets

LGTM

lx commented on pull request Deuxfleurs/garage#640 2023-10-03 15:54:24 +00:00
Add support for binding to unix domain sockets

Yes that is correct, I don't feel that it is necessary to add them for RPC communication. And it would be a bit trickier to do as it would involve modifying the netapp crate as well.

My…

lx commented on pull request Deuxfleurs/garage#640 2023-10-03 15:44:23 +00:00
Add support for binding to unix domain sockets

I think there is a mistake, UNIX sockets are still not supported for rpc_bind_addr, right?

Should I also mention which version the feature was introduced in? Which version would will that…

lx commented on pull request Deuxfleurs/garage#640 2023-10-03 08:19:19 +00:00
Add support for binding to unix domain sockets

Great work, thank you very much! Could you add relevant documentation in the reference section for the config file? (doc/book/reference-manual/configuration.md)

lx pushed to main at Deuxfleurs/nixcfg 2023-10-02 14:59:06 +00:00
c4f3dece14 update tricot
lx pushed tag docker-50 to Deuxfleurs/tricot 2023-10-02 14:48:02 +00:00
lx pushed tag docker-51 to Deuxfleurs/tricot 2023-10-02 14:48:02 +00:00
lx pushed tag docker-49 to Deuxfleurs/tricot 2023-10-02 14:48:01 +00:00
lx pushed to main at Deuxfleurs/tricot 2023-10-02 14:48:00 +00:00
14325395f6 dockerfile: update rustc
lx merged pull request Deuxfleurs/garage#641 2023-10-02 14:30:54 +00:00
doc: update endpoint_url documentation
lx pushed to main at Deuxfleurs/garage 2023-10-02 14:30:54 +00:00
16aa418e47 Merge pull request 'doc: update endpoint_url documentation' (#641) from flokli/garage:aws-endpoint-url into main
cb359b4434 doc: update endpoint_url documentation
Compare 2 commits »