Deuxfleurs/garage
34
65
Fork 83
Code Issues95 Pull requests16 Releases32 Wiki Activity

Allow linking against system-provided libraries (libsodium, libsqlite, libzstd) #370

Merged
lx merged 2 commits from jirutka/garage:system-libs into improve-deps 2022-09-05 10:18:09 +00:00
Conversation 1 Commits 2 Files changed 5 +17 -1
jirutka commented 2022-09-03 17:16:48 +00:00
Contributor

Please see description the commits.

Please see description the commits.
jirutka added 2 commits 2022-09-03 17:16:49 +00:00 
If this feature is enabled, libsodium-sys and zstd-sys will link
dynamically against system-provided libraries instead of building
and linking statically the bundled (possibly outdated and vulnerable)
copies of them. This feature is intended mainly for linux package
maintainers.
Unfortunately, rusqlite uses the opposite logic for enabling/disabling
bundled libraries to others (libsodium-sys, zstd-sys). Cargo features
are very limited and doesn't allow to enable feature A in a dependency
iff feature B is disabled.

Note, lmdb-rkv-sys doesn't need any special treatment because it
automatically links against system liblmdb if found via pkgconf.

Linux distros should build garage with
`--no-default-features --features system-libs` to disable bundled-libs
and enable system-libs.
lx changed target branch from main to improve-deps 2022-09-05 10:17:21 +00:00
lx commented 2022-09-05 10:18:04 +00:00
Owner

Thanks, LGTM

I'm merging this into a temporary branch so that I can make a few ajustments on my own (.nix files in particular)

Thanks, LGTM I'm merging this into a temporary branch so that I can make a few ajustments on my own (.nix files in particular)
lx merged commit 7511ba5530 into improve-deps 2022-09-05 10:18:09 +00:00
jirutka deleted branch system-libs 2022-09-05 23:02:05 +00:00
Sign in to join this conversation.
No reviewers
No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind/experimental
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
admin-sdk
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#370
No description provided.
Delete branch "jirutka/garage:system-libs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?