Deuxfleurs/garage
42
42
Fork 58
Code Issues 80 Pull requests 7 Releases 29 Wiki Activity

Allow linking against system-provided libraries (libsodium, libsqlite, libzstd) #370

Merged
lx merged 2 commits from jirutka/garage:system-libs into improve-deps 2022-09-05 10:18:09 +00:00
Conversation 1 Commits 2 Files changed 5 +17 -1
jirutka commented 2022-09-03 17:16:48 +00:00
Contributor
Copy link

Please see description the commits.

Please see description the commits.
jirutka added 2 commits 2022-09-03 17:16:49 +00:00 
If this feature is enabled, libsodium-sys and zstd-sys will link
dynamically against system-provided libraries instead of building
and linking statically the bundled (possibly outdated and vulnerable)
copies of them. This feature is intended mainly for linux package
maintainers.
Allow linking against system-provided libsqlite
Some checks are pending
continuous-integration/drone/push Build is pending
Details
continuous-integration/drone/pr Build is pending
Details
7511ba5530 
Unfortunately, rusqlite uses the opposite logic for enabling/disabling
bundled libraries to others (libsodium-sys, zstd-sys). Cargo features
are very limited and doesn't allow to enable feature A in a dependency
iff feature B is disabled.

Note, lmdb-rkv-sys doesn't need any special treatment because it
automatically links against system liblmdb if found via pkgconf.

Linux distros should build garage with
`--no-default-features --features system-libs` to disable bundled-libs
and enable system-libs.
lx changed target branch from main to improve-deps 2022-09-05 10:17:21 +00:00
lx commented 2022-09-05 10:18:04 +00:00
Owner
Copy link

Thanks, LGTM

I'm merging this into a temporary branch so that I can make a few ajustments on my own (.nix files in particular)

Thanks, LGTM I'm merging this into a temporary branch so that I can make a few ajustments on my own (.nix files in particular)
lx merged commit 7511ba5530 into improve-deps 2022-09-05 10:18:09 +00:00
jirutka deleted branch system-libs 2022-09-05 23:02:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No labels
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#370
No description provided.
Delete branch "jirutka/garage:system-libs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?