Deuxfleurs/garage
48
56
Fork 73
Code Issues 99 Pull requests 13 Releases 30 Wiki Activity

Make OTLP exporter optional and allow building without Prometheus exporter (/metrics) #372

Merged
lx merged 3 commits from jirutka/garage:telemetry-and-metrics into improve-deps 2022-09-06 13:11:33 +00:00
Conversation 3 Commits 3 Files changed 6 +52 -27
jirutka commented 2022-09-04 14:12:05 +00:00
Contributor
Copy link

Please see commit messages.

Please see commit messages.
lx approved these changes 2022-09-05 09:06:58 +00:00
Dismissed
lx left a comment
Owner
Copy link

Thanks for making this, it's pretty much what I imagined. There's just a small issue with the warn! when OTLP is disabled (see below). Also if you have the opportunity of running cargo fmt and checking the cargo clippy lints, that would be nice (depending on your Clippy version, it might report a bunch of lints about Eq/PartialEq which we don't care about).

We also need to update the .nix files to integrate this with our CI but I can do it myself.

Thanks for making this, it's pretty much what I imagined. There's just a small issue with the `warn!` when OTLP is disabled (see below). Also if you have the opportunity of running `cargo fmt` and checking the `cargo clippy` lints, that would be nice (depending on your Clippy version, it might report a bunch of lints about `Eq`/`PartialEq` which we don't care about). We also need to update the `.nix` files to integrate this with our CI but I can do it myself.
src/garage/server.rs Outdated
@ -41,1 +45,4 @@
init_tracing(&export_to, garage.system.id)?;
#[cfg(not(feature = "telemetry-otlp"))]
warn!("Garage was built without OTLP exporter, admin.trace_sink is ignored.");
lx commented 2022-09-05 08:58:16 +00:00
Owner
Copy link

Looks like this will never be called because we are in a #[cfg(feature = "telemetry-otlp")] block

Looks like this will never be called because we are in a `#[cfg(feature = "telemetry-otlp")]` block
jirutka marked this conversation as resolved
lx dismissed lx's review 2022-09-05 09:07:44 +00:00
lx changed target branch from main to improve-deps 2022-09-05 10:21:56 +00:00
lx commented 2022-09-05 10:22:46 +00:00
Owner
Copy link

Changed to merge this into #373 (a temporary branch where I'll do the Nix shenanigans). This caused a conflict in src/garage/Cargo.toml because of #370.

Changed to merge this into #373 (a temporary branch where I'll do the Nix shenanigans). This caused a conflict in `src/garage/Cargo.toml` because of #370.
jirutka force-pushed telemetry-and-metrics from a095c831fc to 75b11bdfc1 2022-09-05 23:11:51 +00:00 Compare
jirutka force-pushed telemetry-and-metrics from 75b11bdfc1 to ea36b9ff90 2022-09-05 23:16:04 +00:00 Compare
jirutka commented 2022-09-05 23:18:28 +00:00
Author
Contributor
Copy link

Okay, I fixed it and rebased against the improve-deps branch.

Okay, I fixed it and rebased against the `improve-deps` branch.
lx commented 2022-09-06 13:11:22 +00:00
Owner
Copy link

Thanks for your contribution!

Thanks for your contribution!
lx merged commit ed7796924b into improve-deps 2022-09-06 13:11:33 +00:00
jirutka deleted branch telemetry-and-metrics 2022-09-25 12:54:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#372
No description provided.
Delete branch "jirutka/garage:telemetry-and-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?