add support for caching headers #49
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#49
Loading…
Reference in New Issue
No description provided.
Delete Branch "trinity-1686a/garage:cache-headers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fix #48
This should be compliant with rfc7232 except it does not implement
If-Match
andIf-Unmodified-Since
as they make sense mostly for state-changing methods, to not overwrite modifications made by other user-agents.LGTM. Before I merge, is there a possibility that a request contains both
If-None-Match
andIf-Modified-Since
, and is the behaviour specified in that case?It is possible, and is even usually the case. In this situation
If-None-Match
takes precedence andIf-Modified-Since
is ignored (as per 6.Precedence from rfc7232). The rational being that etag based matching is more accurate, it has no issue with sub-second precision for instance (in case of very fast updates)Thank you for the precision. That's fine.