Deuxfleurs
/
garage
42
39
Fork 55
Code Issues 71 Pull Requests 8 Releases 29 Wiki Activity

add support for caching headers #49

Merged
lx merged 1 commits from trinity-1686a/garage:cache-headers into master 2021-03-18 18:45:04 +00:00
Conversation 3 Commits 1 Files Changed 3 +46 -3
trinity-1686a commented 2021-03-18 14:56:41 +00:00
Owner
Copy Link

fix #48
This should be compliant with rfc7232 except it does not implement If-Match and If-Unmodified-Since as they make sense mostly for state-changing methods, to not overwrite modifications made by other user-agents.

fix #48 This should be compliant with [rfc7232](https://tools.ietf.org/html/rfc7232) except it does not implement `If-Match` and `If-Unmodified-Since` as they make sense mostly for state-changing methods, to not overwrite modifications made by other user-agents.
trinity-1686a added 1 commit 2021-03-18 14:56:44 +00:00
continuous-integration/drone/pr Build is failing Details
b4c903371c add support for caching headers
lx commented 2021-03-18 18:05:11 +00:00
Owner
Copy Link

LGTM. Before I merge, is there a possibility that a request contains both If-None-Match and If-Modified-Since, and is the behaviour specified in that case?

LGTM. Before I merge, is there a possibility that a request contains both `If-None-Match` and `If-Modified-Since`, and is the behaviour specified in that case?
lx closed this pull request 2021-03-18 18:27:21 +00:00
lx reopened this pull request 2021-03-18 18:35:58 +00:00
lx changed target branch from dev-0.2 to master 2021-03-18 18:36:44 +00:00
trinity-1686a commented 2021-03-18 18:43:21 +00:00
Author
Owner
Copy Link

It is possible, and is even usually the case. In this situation If-None-Match takes precedence and If-Modified-Since is ignored (as per 6.Precedence from rfc7232). The rational being that etag based matching is more accurate, it has no issue with sub-second precision for instance (in case of very fast updates)

It is possible, and is even usually the case. In this situation `If-None-Match` takes precedence and `If-Modified-Since` is ignored (as per 6.Precedence from rfc7232). The rational being that etag based matching is more accurate, it has no issue with sub-second precision for instance (in case of very fast updates)
lx commented 2021-03-18 18:44:30 +00:00
Owner
Copy Link

Thank you for the precision. That's fine.

Thank you for the precision. That's fine.
lx merged commit bfa0ff8f82 into master 2021-03-18 18:45:04 +00:00
trinity-1686a deleted branch cache-headers 2021-03-18 18:49:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#49
No description provided.
Delete Branch "trinity-1686a/garage:cache-headers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?