Correctly encode ampersand #61

Merged

lx merged 2 commits from bug/ampersand into main

2021-04-27 21:15:04 +00:00

quentin commented

2021-04-27 19:47:52 +00:00

Owner

Fixes #59.
Currently it works on my machine but not on the CI.
I suspect that s3cmd is too old in the Docker container.
Edit: no, the bug was due to locales missing xD

Fixes #59. Currently it works on my machine but not on the CI. I suspect that s3cmd is too old in the Docker container. Edit: no, the bug was due to locales missing xD

quentin changed title from ~~[WIP] Correctly encode ampersand~~ to Correctly encode ampersand

2021-04-27 20:09:36 +00:00

lx commented

2021-04-27 20:54:27 +00:00

Owner

Would you mind rewriting the history so that it contains two commits:

a first commit before the patch, containing only the test case and exhibiting the issue
a second commit with only the patch that shows that the patch fixes the issue

To do that, squash your three commits into one using git rebase -i main, and then ammend the commit to remove the fix to encoding.rs. Then create a new commit that contains the fix.

Thanks

EDIT: nvm i'll do it

Would you mind rewriting the history so that it contains two commits: - a first commit before the patch, containing only the test case and exhibiting the issue - a second commit with only the patch that shows that the patch fixes the issue To do that, squash your three commits into one using `git rebase -i main`, and then ammend the commit to remove the fix to `encoding.rs`. Then create a new commit that contains the fix. Thanks EDIT: nvm i'll do it

lx force-pushed bug/ampersand from e842eda594 to 642186c530

2021-04-27 21:11:17 +00:00

Compare