pict-rs broken after upgrading from 0.9.0 to 0.9.2 #752

New Issue

Closed

opened 2024-03-03 19:43:50 +00:00 by asonix · 3 comments

asonix commented

2024-03-03 19:43:50 +00:00

Contributor

Hey there, I recently tried upgrading to 0.9.2 and ran into an issue regarding "anonymous access"

Relevant logs:

2024-03-03T19:30:07.620881Z  INFO garage_api::generic_server: [::ffff:10.42.15.171]:58968 HEAD /pict-rs/?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=[redacted]&X-Amz-Date=20240303T193007Z&X-Amz-Expires=15&X-Amz-SignedHeaders=host&X-Amz-Signature=[redacted]
2024-03-03T19:30:07.621268Z  INFO garage_api::generic_server: Response: error 403 Forbidden, Forbidden: Garage does not support anonymous access yet

it seems there were changes around param parsing between 0.9.0 and 0.9.2, that's likely related

Hey there, I recently tried upgrading to 0.9.2 and ran into an issue regarding "anonymous access" Relevant logs: ``` 2024-03-03T19:30:07.620881Z INFO garage_api::generic_server: [::ffff:10.42.15.171]:58968 HEAD /pict-rs/?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=[redacted]&X-Amz-Date=20240303T193007Z&X-Amz-Expires=15&X-Amz-SignedHeaders=host&X-Amz-Signature=[redacted] 2024-03-03T19:30:07.621268Z INFO garage_api::generic_server: Response: error 403 Forbidden, Forbidden: Garage does not support anonymous access yet ``` it seems there were changes around param parsing between 0.9.0 and 0.9.2, that's likely related

asonix commented

2024-03-03 19:46:14 +00:00

Author

Contributor

I'm trying out 0.9.1 now

asonix commented

2024-03-03 19:50:42 +00:00

Author

Contributor

0.9.1 seems fine, issue was introduced in 0.9.2

asonix commented

2024-03-03 20:26:52 +00:00

Author

Contributor

Seems like the issue might be a missing to_lowercase in src/api/signature/payload.rs on line 199

looking through #735 it seems that the old code had a to_lowercase when parsing the query, and the new code doesn't

Seems like the issue might be a missing `to_lowercase` in `src/api/signature/payload.rs` on line 199 looking through https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/735 it seems that the old code had a `to_lowercase` when parsing the query, and the new code doesn't