Split presigned signature verification + fix conditions #735
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#735
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix-presigned"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The objective of this PR is to split code paths for regular signature verification, and verification of pre-signed URLs. The idea behind this is that we want a clearer view of what is verified upon signature verification, because it isn't exactly the same thing for both (we have to check with the official docs). Also we want to check that the correct set of headers is signed, I don't think we do it now but Amazon says that all x-amz-* headers must be included in the signedheaders list if they are to be used.
[fix-presigned] WIP: try to split presigned/normal signature verificationto WIP: split presigned signature verification + fix checksWIP: split presigned signature verification + fix checksto WIP: split presigned signature verification + fix conditionsWIP: split presigned signature verification + fix conditionsto Split presigned signature verification + fix conditionse610e16abb
to90cab5b8f2
lx referenced this pull request2024-03-01 14:14:56 +00:00