Lowercase query parameter keys when parsing #753
No reviewers
Labels
No labels
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#753
Loading…
Reference in a new issue
No description provided.
Delete branch "asonix/garage:main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fixes #752
Just this isn't enough. Getting the following now:
it seems the
canonical_request
has lowercased keys, which ends up generating a different signing string than the client which has title-cased keysgarage 0.9.1's canonical request:
garage 0.9.2's canonical request:
I've deployed this on my network and it seems to be working
Hello, sorry for breaking this and thanks for fixing it.
@asonix Can you make your fork of the repo public? The CI is refusing to run currently as it cannot access your code.
Closing in favor of #756. I've kept your comits for the fix, thank you.
Pull request closed