don't modify postobject request before validating policy #850
No reviewers
Labels
No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#850
Loading…
Reference in a new issue
No description provided.
Delete branch "trinity-1686a/garage:fix-acl-postobject"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fix #825
while
tagging
(which was the correct value instead oftag
) is not mentioned anywhere in the post policy documentation, other sources mention it as valid conditions inside a policy, so process it like everything else.don't be smart about how we process
acl
as we don't support them anyway. If/when we add support for ACLs, mapping acl=>x-amz-acl should happen after policy has been verified.I trust you on this one! Thanks for the patch.