don't modify postobject request before validating policy #850

Merged
lx merged 1 commit from trinity-1686a/garage:fix-acl-postobject into main 2024-08-24 10:49:14 +00:00

fix #825

while tagging (which was the correct value instead of tag) is not mentioned anywhere in the post policy documentation, other sources mention it as valid conditions inside a policy, so process it like everything else.
don't be smart about how we process acl as we don't support them anyway. If/when we add support for ACLs, mapping acl=>x-amz-acl should happen after policy has been verified.

fix #825 while `tagging` (which was the correct value instead of `tag`) is not mentioned anywhere in the [post policy documentation](https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-HTTPPOSTConstructPolicy.html), [other](https://dev.to/timetxt/amazon-s3-web-based-upload-object-with-post-request-and-presigned-url-in-python-boto3-5be5) [sources](https://repost.aws/questions/QUVwHSKoAgR7SC7ewXNvsJww/s3-post-policy-with-tags) mention it as valid conditions inside a policy, so process it like everything else. don't be smart about how we process `acl` as we don't support them anyway. If/when we add support for ACLs, mapping acl=>x-amz-acl should happen after policy has been verified.
lx was assigned by trinity-1686a 2024-08-10 18:20:54 +00:00
trinity-1686a added 1 commit 2024-08-10 18:20:55 +00:00
don't modify postobject request before validating policy
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
f190032589
trinity-1686a added the
kind
wrong-behavior
scope
s3-api
labels 2024-08-18 01:47:30 +00:00
Owner

I trust you on this one! Thanks for the patch.

I trust you on this one! Thanks for the patch.
lx merged commit 3e711bc110 into main 2024-08-24 10:49:14 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#850
No description provided.