Introduce Controller/Helper Taxonomy to handler Errors separately #11

Closed

quentin wants to merge 3 commits from feature/refactor-s3 into master

quentin commented

2020-11-11 10:23:42 +00:00

Owner

I do not have a strong opinion on this PR, it is more a way to start a conversation.
The original motivation was to mutualize error handling between api and web.
After working on this patch, it seems that, if it makes sense now, in the future it will not: we answer differently to machines and humans...
I still submitted it, because I think that the renaming could add some clarity to the code: helpers and controllers are generic names in other frameworks.
I recognize that it remains subjective and that this patch add some complexity, especially through the way I chose to implement make_infallible (via a trait and not a simple function).

I am open to discuss everything and do not hesitate to refuse the PR ;)

I do not have a strong opinion on this PR, it is more a way to start a conversation. The original motivation was to mutualize error handling between api and web. After working on this patch, it seems that, if it makes sense now, in the future it will not: we answer differently to machines and humans... I still submitted it, because I think that the renaming could add some clarity to the code: helpers and controllers are generic names in other frameworks. I recognize that it remains subjective and that this patch add some complexity, especially through the way I chose to implement `make_infallible` (via a trait and not a simple function). I am open to discuss everything and do not hesitate to refuse the PR ;)