Deuxfleurs/garage
48
56
Fork 73
Code Issues 99 Pull requests 13 Releases 30 Wiki Activity

map range-error to the right http error code #157

Merged
lx merged 4 commits from trinity-1686a/garage:range-error into main 2021-11-29 10:52:42 +00:00
Conversation 0 Commits 4 Files changed 5 +46 -14
trinity-1686a commented 2021-11-19 19:19:09 +00:00
Owner
Copy link

fix #140

fix #140
trinity-1686a added the
scope
s3-api
 label 2021-11-19 19:19:09 +00:00
trinity-1686a added 1 commit 2021-11-19 19:19:10 +00:00
map range-error to the right http error code
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8c45ad8e38
lx requested changes 2021-11-22 11:00:53 +00:00
lx left a comment
Owner
Copy link

There are other code paths that should reeturn 416 instead of 400:

There are other code paths that should reeturn 416 instead of 400: - <https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_get.rs#L239> - <https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_get.rs#L161> - maybe some more ?
trinity-1686a added 1 commit 2021-11-25 17:30:40 +00:00
remove dead code and handle mutli-range by sending whole file
All checks were successful
continuous-integration/drone/pr Build is passing
Details
991279cd40
trinity-1686a added 1 commit 2021-11-27 10:42:38 +00:00
send content-range on invalid range error
Some checks failed
continuous-integration/drone/pr Build is failing
Details
36e104b665
trinity-1686a added 1 commit 2021-11-27 14:56:05 +00:00
add range header on 416 on web request
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8a43ede301
trinity-1686a requested review from lx 2021-11-27 16:21:11 +00:00
lx approved these changes 2021-11-29 10:50:37 +00:00
lx left a comment
Owner
Copy link

LGTM

LGTM
src/api/api_server.rs
@ -71,1 +70,3 @@
.body(body)?;
.header("Content-Type", "application/xml");
if let Some(header_map) = http_error_builder.headers_mut() {
lx commented 2021-11-29 10:47:34 +00:00
Owner
Copy link

It's kind of confusing that there is an if but as I understand the codepath is always taken. Using .unwrap() on .headers_mut() would have seemed more logical.

It's kind of confusing that there is an `if` but as I understand the codepath is always taken. Using `.unwrap()` on `.headers_mut()` would have seemed more logical.
lx merged commit 7f26ed55cd into main 2021-11-29 10:52:42 +00:00
lx referenced this pull request from a commit 2021-11-29 10:52:43 +00:00
Improved handling of HTTP ranges
trinity-1686a deleted branch range-error 2021-11-29 10:57:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#157
No description provided.
Delete branch "trinity-1686a/garage:range-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?