Deuxfleurs/garage
48
56
Fork 73
Code Issues 100 Pull requests 13 Releases 30 Wiki Activity

Implement CORS #183

Merged
quentin merged 2 commits from bucket-cors into main 2022-01-24 17:04:07 +00:00
Conversation 1 Commits 2 Files changed 12 +566 -86
lx commented 2022-01-07 16:06:41 +00:00
Owner
Copy link

Fixes #138

  • Add CORS configuration to Bucket model
  • Implement {Put,Get,Delete}BucketCors
  • Return CORS headers in web
  • Support the OPTIONS method in api
  • Return CORS headers in api
  • fix documentation
Fixes #138 - [x] Add CORS configuration to Bucket model - [x] Implement {Put,Get,Delete}BucketCors - [x] Return CORS headers in `web` - [x] Support the OPTIONS method in `api` - [x] Return CORS headers in `api` - [x] fix documentation
lx force-pushed bucket-cors from 05cb5b0c8b to 4f091f3f2c 2022-01-07 16:16:31 +00:00 Compare
lx added the
scope
s3-api
 label 2022-01-10 11:31:40 +00:00
lx force-pushed bucket-cors from 4f091f3f2c to 9950ab92e3 2022-01-10 13:18:27 +00:00 Compare
lx force-pushed bucket-cors from 9950ab92e3 to 68bd118266 2022-01-10 13:59:28 +00:00 Compare
lx force-pushed bucket-cors from 68bd118266 to efd153b034 2022-01-10 14:01:46 +00:00 Compare
lx force-pushed bucket-cors from efd153b034 to 013e37e5d2 2022-01-10 15:38:31 +00:00 Compare
lx force-pushed bucket-cors from 013e37e5d2 to 28bc685e52 2022-01-13 12:42:36 +00:00 Compare
lx force-pushed bucket-cors from 28bc685e52 to bb8c2d4bc0 2022-01-13 13:27:41 +00:00 Compare
lx force-pushed bucket-cors from bb8c2d4bc0 to 4b00b95734 2022-01-13 13:29:32 +00:00 Compare
lx force-pushed bucket-cors from 4b00b95734 to c7cc1403e9 2022-01-13 13:30:13 +00:00 Compare
quentin commented 2022-01-13 16:12:38 +00:00
Owner
Copy link

GetBucketCors does not work on my machine, it returns an empty response:

$ aws s3api put-bucket-cors --bucket peertube-playlist --cors-configuration '{"CORSRules":[{"AllowedHeaders":["*"],"AllowedMethods":["GET"],"AllowedOrigins":["*"],"ExposeHeaders":[]}]}'

$ aws s3api get-bucket-cors --bucket peertube-playlist
GetBucketCors does not work on my machine, it returns an empty response: ``` $ aws s3api put-bucket-cors --bucket peertube-playlist --cors-configuration '{"CORSRules":[{"AllowedHeaders":["*"],"AllowedMethods":["GET"],"AllowedOrigins":["*"],"ExposeHeaders":[]}]}' $ aws s3api get-bucket-cors --bucket peertube-playlist ```
lx force-pushed bucket-cors from c7cc1403e9 to bed3106c6a 2022-01-13 16:27:26 +00:00 Compare
trinity-1686a added a new dependency 2022-01-14 23:55:55 +00:00
#189 refactor-router
trinity-1686a removed a dependency 2022-01-17 14:53:43 +00:00
#189 refactor-router
lx added 4 commits 2022-01-17 15:13:35 +00:00
Support STREAMING-AWS4-HMAC-SHA256-PAYLOAD (#64) (#156)
All checks were successful
continuous-integration/drone/push Build is passing
Details
b45dcc1925 
Closes #64.

Reviewed-on: #156
Co-authored-by: Jill <kokakiwi@deuxfleurs.fr>
Co-committed-by: Jill <kokakiwi@deuxfleurs.fr>
Fix Multipart Upload with WinSCP (#164) (#193)
All checks were successful
continuous-integration/drone/push Build is passing
Details
fdcddbe168 
Closes #164.

Reviewed-on: #193
Co-authored-by: Jill <kokakiwi@deuxfleurs.fr>
Co-committed-by: Jill <kokakiwi@deuxfleurs.fr>
Fix extreme value to be less extreme so that integration test works on 32bits
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone Build is passing
Details
7c049f1c94
refactor s3_router and api_server to make unused Endpoint parameters more obvious
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
178e35f868
lx changed target branch from improve-website-config to main 2022-01-17 15:24:46 +00:00
lx changed title from Implement CORS on website endpoint to Implement CORS 2022-01-17 17:46:52 +00:00
lx force-pushed bucket-cors from 02b706a923 to 47c37153a6 2022-01-17 17:50:34 +00:00 Compare
lx force-pushed bucket-cors from 47c37153a6 to 934d076844 2022-01-17 17:57:23 +00:00 Compare
lx force-pushed bucket-cors from 934d076844 to ea7fb901eb 2022-01-24 10:58:07 +00:00 Compare
lx force-pushed bucket-cors from 848b05add4 to 513a6b15f9 2022-01-24 11:32:37 +00:00 Compare
quentin merged commit 513a6b15f9 into main 2022-01-24 17:04:07 +00:00
quentin deleted branch bucket-cors 2022-01-24 17:04:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#183
No description provided.
Delete branch "bucket-cors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?