Deuxfleurs/garage
39
56
Fork 74
Code Issues 103 Pull requests 15 Releases 30 Wiki Activity

Handle part_number in HeadObject and GetObject (#191) #192

Merged
lx merged 2 commits from get-head-part-number into main 2022-01-24 21:00:34 +00:00
Conversation 0 Commits 2 Files changed 5 +268 -100
lx commented 2022-01-13 14:45:58 +00:00
Owner
Copy link
No description provided.
lx force-pushed get-head-part-number from 0110ae5f1f to f23b61a7f3 2022-01-13 14:46:52 +00:00 Compare
trinity-1686a reviewed 2022-01-13 16:23:54 +00:00
src/api/error.rs Outdated
@ -55,2 +55,4 @@
BucketNotEmpty,
/// Parts specified in CMU request do not match parts actually uploaded
#[error(display = "Parts given to CompleteMultipartUpload do not match uploade dparts")]
trinity-1686a commented 2022-01-13 16:12:18 +00:00
Owner
Copy link

typo

typo
src/api/s3_get.rs Outdated
@ -121,0 +123,4 @@
if let ObjectVersionData::Inline(_, _) = version_data {
// Not a multipart upload
return Err(Error::BadRequest(
"Cannt process part_number argument: not a multipart upload".into(),
trinity-1686a commented 2022-01-13 16:12:27 +00:00
Owner
Copy link

typo

typo
src/api/s3_put.rs Outdated
@ -446,0 +454,4 @@
.iter()
.zip(body_list_of_parts.iter().skip(1))
.all(|(p1, p2)| p1.part_number + 1 == p2.part_number)
{
trinity-1686a commented 2022-01-13 16:19:43 +00:00
Owner
Copy link

to verify, but I think this is stricter than AWS : I believe I've read somewhere it's possible to have holes between part number, so 2, 4, 6 would be a correct sequence. Will try against AWS when I have time

to verify, but I think this is stricter than AWS : I believe I've read somewhere it's possible to have holes between part number, so `2, 4, 6` would be a correct sequence. Will try against AWS when I have time
👍 1
trinity-1686a commented 2022-01-15 12:15:18 +00:00
Owner
Copy link

I can confirm AWS accept providing the part number list 2, 4, so it neither require starting from 1, nor be sequential, only ordered and between 1 and 10000

I can confirm AWS accept providing the part number list `2, 4`, so it neither require starting from 1, nor be sequential, only ordered and between 1 and 10000
👍 1
lx force-pushed get-head-part-number from f23b61a7f3 to 3c5945a585 2022-01-17 15:19:22 +00:00 Compare
lx force-pushed get-head-part-number from 3c5945a585 to 26a7309839 2022-01-18 11:16:35 +00:00 Compare
lx force-pushed get-head-part-number from 26a7309839 to 43c27eef9b 2022-01-18 11:18:50 +00:00 Compare
lx force-pushed get-head-part-number from 43c27eef9b to 0c7834bfa7 2022-01-24 11:21:44 +00:00 Compare
quentin approved these changes 2022-01-24 17:56:10 +00:00
lx force-pushed get-head-part-number from 0c7834bfa7 to 338b1b83ee 2022-01-24 20:04:45 +00:00 Compare
lx merged commit 338b1b83ee into main 2022-01-24 21:00:34 +00:00
trinity-1686a approved these changes 2022-01-24 21:33:39 +00:00
trinity-1686a left a comment
Owner
Copy link

multiple small diffences with AWS. I wouldn't consider them blocking, if you want to merge this quiclky, just open an issue for them.

Overall, lgtm

multiple small diffences with AWS. I wouldn't consider them blocking, if you want to merge this quiclky, just open an issue for them. Overall, lgtm
src/api/s3_get.rs
@ -121,0 +123,4 @@
if let ObjectVersionData::Inline(_, _) = version_data {
// Not a multipart upload
return Err(Error::BadRequest(
"Cannot process part_number argument: not a multipart upload".into(),
trinity-1686a commented 2022-01-24 21:09:56 +00:00
Owner
Copy link

minor missmatch with AWS : if not multipart, AWS consider everything is contained in part 1.

minor missmatch with AWS : if not multipart, AWS consider everything is contained in part 1.
src/api/s3_get.rs
@ -121,0 +151,4 @@
Ok(object_headers(object_version, version_meta)
.header(CONTENT_LENGTH, format!("{}", part_size))
.header("x-amz-mp-parts-count", format!("{}", n_parts))
.status(StatusCode::OK)
trinity-1686a commented 2022-01-24 21:29:07 +00:00
Owner
Copy link

AWS returns byte range headers and HTTP 206 (Partial Content) as if it was a range request

Accept-Ranges: bytes
Content-Range: bytes 0-147/148
AWS returns byte range headers and HTTP 206 (Partial Content) as if it was a range request ``` Accept-Ranges: bytes Content-Range: bytes 0-147/148 ```
src/api/s3_get.rs
@ -316,0 +319,4 @@
.ok_or(Error::NoSuchKey)?
} else {
return Err(Error::BadRequest(
"Cannot handle part_number: not a multipart upload.".into(),
trinity-1686a commented 2022-01-24 21:16:41 +00:00
Owner
Copy link

Same as above

Same as above
src/api/s3_get.rs
@ -316,0 +337,4 @@
let part_size = blocks.iter().map(|(_, b)| b.size).sum();
if let Some(r) = parse_range_header(req, part_size)? {
trinity-1686a commented 2022-01-24 21:23:40 +00:00
Owner
Copy link

AWS does not support this kind of request (InvalidRequest: Cannot specify both Range header and partNumber query parameter).
I'm not sure if we should support it, S3 libraries won't ever call that, and it's additional code to maitain. On the other hand, it's not a lot of code, so this message is purely informative, and not necessary requiring any changes

AWS does not support this kind of request (InvalidRequest: Cannot specify both Range header and partNumber query parameter). I'm not sure if we should support it, S3 libraries won't ever call that, and it's additional code to maitain. On the other hand, it's not a lot of code, so this message is purely informative, and not necessary requiring any changes
src/api/s3_get.rs
@ -316,0 +355,4 @@
Ok(object_headers(object_version, version_meta)
.header(CONTENT_LENGTH, format!("{}", part_size))
.status(StatusCode::OK)
trinity-1686a commented 2022-01-24 21:29:31 +00:00
Owner
Copy link

Same as above

Same as above
Sign in to join this conversation.
Reviewers
No reviewers
quentin
trinity-1686a
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#192
No description provided.
Delete branch "get-head-part-number"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?