Propose ETag fix #23

Merged

lx merged 1 commit from bug/etag into master

2020-12-06 14:28:03 +00:00

lx commented

2020-12-05 15:03:42 +00:00

Owner

This fix does several things:

Generate an etag for multipart uploads
Do not return ETag on get/head requests if there is no ETag stored (for objects created by previous versions)
When returning ETag on get/head, add missing double quotes

@quentin could you check if this patch improves any of your issues ?

Is it better to return no ETag header rather than an ETag header with an empty value? (It should be, because empty etag is invalid)
Does the aws s3 CLI complain about multipart etags not being computed strictly the same as they are on s3 ? My guess is that it shouldn't care.

This fix does several things: - Generate an etag for multipart uploads - Do not return ETag on get/head requests if there is no ETag stored (for objects created by previous versions) - When returning ETag on get/head, add missing double quotes @quentin could you check if this patch improves any of your issues ? - Is it better to return no ETag header rather than an ETag header with an empty value? (It should be, because empty etag is invalid) - Does the aws s3 CLI complain about multipart etags not being computed **strictly the same** as they are on s3 ? My guess is that it shouldn't care.

lx referenced this pull request from a commit

2020-12-06 14:28:00 +00:00

Merge pull request 'Propose ETag fix' (#23) from bug/etag into master Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/23

lx merged commit 857440f192 into master

2020-12-06 14:28:02 +00:00

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#23

No description provided.