Deuxfleurs
/
garage
43
37
Fork 55
Code Issues 69 Pull Requests 4 Releases 29 Wiki Activity

Enable daemonset deployment using the helm chart #409

Merged
lx merged 5 commits from kaiyou/garage:feat-k8s-daemonset into main 2023-01-26 21:07:58 +00:00
Conversation 3 Commits 5 Files Changed 4 +35 -7
kaiyou commented 2022-10-29 19:19:55 +00:00
Contributor
Copy Link

DaemonSet is a k8s resource that schedules one instance per node, which is useful for some garage deployment use cases, including managing garage nodes using k8s node labels.

This PR introduces a new value section named deployment, which now holds the replicaCount, plus a new kind value for the workload kind: either StatefulSet or DaemonSet.

When set to StatefulSet (default), behavior is unchanged. Thus only moving the replicaCount was added to the docs at this point.

When set to DaemonSet, the Helm chart deploys a daemonset indeed, and persistence is switched to a host path.

Currently tagged as WIP, this is my first PR and clearly it requires manual testing from peers :)

DaemonSet is a k8s resource that schedules one instance per node, which is useful for some garage deployment use cases, including managing garage nodes using k8s node labels. This PR introduces a new value section named `deployment`, which now holds the `replicaCount`, plus a new `kind` value for the workload kind: either `StatefulSet` or `DaemonSet`. When set to `StatefulSet` (default), behavior is unchanged. Thus only moving the `replicaCount` was added to the docs at this point. When set to `DaemonSet`, the Helm chart deploys a daemonset indeed, and persistence is switched to a host path. --- Currently tagged as WIP, this is my first PR and clearly it requires manual testing from peers :)
kaiyou changed title from Enable daemonset deployment using the helm chart to WIP: Enable daemonset deployment using the helm chart 2022-10-29 19:23:08 +00:00
kaiyou force-pushed feat-k8s-daemonset from bf5868a71d to 4787685912 2022-11-18 19:02:09 +00:00 Compare
kaiyou commented 2022-11-18 19:16:49 +00:00
Author
Contributor
Copy Link

This has been running on our production cluster for some time now. It is still missing a version bump, what would the policy recommend? Should I go for 0.2.0 due to breaking API change?

This has been running on our production cluster for some time now. It is still missing a version bump, what would the policy recommend? Should I go for 0.2.0 due to breaking API change?
maximilien requested review from maximilien 2022-12-12 08:42:33 +00:00
kaiyou force-pushed feat-k8s-daemonset from 4787685912 to e852c91d18 2022-12-25 12:28:49 +00:00 Compare
kaiyou added 1 commit 2022-12-25 12:30:39 +00:00
continuous-integration/drone/pr Build is passing Details
559e924cc2 Bump the helm chart version
kaiyou commented 2022-12-25 12:34:10 +00:00
Author
Contributor
Copy Link

I went with 0.3.0, removing WIP! Please note this partially conflicts with #425 while not incompatible, so depending on which is merged first, the other one will require changes: I am fine with either.

I went with 0.3.0, removing WIP! Please note this partially conflicts with https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/425 while not incompatible, so depending on which is merged first, the other one will require changes: I am fine with either.
kaiyou changed title from WIP: Enable daemonset deployment using the helm chart to Enable daemonset deployment using the helm chart 2022-12-25 12:34:18 +00:00
lx commented 2023-01-26 16:30:08 +00:00
Owner
Copy Link

Is this alive?

Is this alive?
lx merged commit a08e01f17a into main 2023-01-26 21:07:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
maximilien
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#409
No description provided.
Delete Branch "kaiyou/garage:feat-k8s-daemonset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?