Deuxfleurs/garage
41
56
Fork 73
Code Issues 99 Pull requests 14 Releases 30 Wiki Activity

Enable daemonset deployment using the helm chart #409

Merged
lx merged 5 commits from kaiyou/garage:feat-k8s-daemonset into main 2023-01-26 21:07:58 +00:00
Conversation 3 Commits 5 Files changed 4 +35 -7
kaiyou commented 2022-10-29 19:19:55 +00:00
Contributor
Copy link

DaemonSet is a k8s resource that schedules one instance per node, which is useful for some garage deployment use cases, including managing garage nodes using k8s node labels.

This PR introduces a new value section named deployment, which now holds the replicaCount, plus a new kind value for the workload kind: either StatefulSet or DaemonSet.

When set to StatefulSet (default), behavior is unchanged. Thus only moving the replicaCount was added to the docs at this point.

When set to DaemonSet, the Helm chart deploys a daemonset indeed, and persistence is switched to a host path.

Currently tagged as WIP, this is my first PR and clearly it requires manual testing from peers :)

DaemonSet is a k8s resource that schedules one instance per node, which is useful for some garage deployment use cases, including managing garage nodes using k8s node labels. This PR introduces a new value section named `deployment`, which now holds the `replicaCount`, plus a new `kind` value for the workload kind: either `StatefulSet` or `DaemonSet`. When set to `StatefulSet` (default), behavior is unchanged. Thus only moving the `replicaCount` was added to the docs at this point. When set to `DaemonSet`, the Helm chart deploys a daemonset indeed, and persistence is switched to a host path. --- Currently tagged as WIP, this is my first PR and clearly it requires manual testing from peers :)
kaiyou added 1 commit 2022-10-29 19:19:55 +00:00
Enable daemonset deployment using the helm chart
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f285cb6ecf 
DaemonSet is a k8s resource that schedules one instance per node,
which is useful for some garage deployment use cases, including
managing garage nodes using k8s node labels
kaiyou changed title from Enable daemonset deployment using the helm chart to WIP: Enable daemonset deployment using the helm chart 2022-10-29 19:23:08 +00:00
kaiyou added 1 commit 2022-11-06 16:48:04 +00:00
Fix volume handling and persistence flag
All checks were successful
continuous-integration/drone/pr Build is passing
Details
bf5868a71d
kaiyou force-pushed feat-k8s-daemonset from bf5868a71d to 4787685912 2022-11-18 19:02:09 +00:00 Compare
kaiyou commented 2022-11-18 19:16:49 +00:00
Author
Contributor
Copy link

This has been running on our production cluster for some time now. It is still missing a version bump, what would the policy recommend? Should I go for 0.2.0 due to breaking API change?

This has been running on our production cluster for some time now. It is still missing a version bump, what would the policy recommend? Should I go for 0.2.0 due to breaking API change?
maximilien requested review from maximilien 2022-12-12 08:42:33 +00:00
kaiyou force-pushed feat-k8s-daemonset from 4787685912 to e852c91d18 2022-12-25 12:28:49 +00:00 Compare
kaiyou added 1 commit 2022-12-25 12:30:39 +00:00
Bump the helm chart version
All checks were successful
continuous-integration/drone/pr Build is passing
Details
559e924cc2
kaiyou commented 2022-12-25 12:34:10 +00:00
Author
Contributor
Copy link

I went with 0.3.0, removing WIP! Please note this partially conflicts with #425 while not incompatible, so depending on which is merged first, the other one will require changes: I am fine with either.

I went with 0.3.0, removing WIP! Please note this partially conflicts with https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/425 while not incompatible, so depending on which is merged first, the other one will require changes: I am fine with either.
kaiyou changed title from WIP: Enable daemonset deployment using the helm chart to Enable daemonset deployment using the helm chart 2022-12-25 12:34:18 +00:00
lx commented 2023-01-26 16:30:08 +00:00
Owner
Copy link

Is this alive?

Is this alive?
lx merged commit a08e01f17a into main 2023-01-26 21:07:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
maximilien
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#409
No description provided.
Delete branch "kaiyou/garage:feat-k8s-daemonset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?