Refactor how things are migrated #461

Merged

lx merged 9 commits from format-migration into main 2023-01-03 15:28:25 +00:00

Conversation 0 Commits 9 Files changed 42 +834 -872

lx commented 2023-01-03 13:45:22 +00:00

Owner

Copy link

• New trait for things that have old versions from which to be migrated
  • Use it for tables and for the Persister object
• Make explicit places where non-versioned encoding is used, don't use rmp_serde directly but a wrapper in garage_util
• Reorganize code for S3 tables where there were migrations from formats of v0.5

And also:

• add k2v to default features
• silence clippy warning about uppercase things in router

- [x] New trait for things that have old versions from which to be migrated - [x] Use it for tables and for the Persister object - [x] Make explicit places where non-versioned encoding is used, don't use rmp_serde directly but a wrapper in garage_util - [x] Reorganize code for S3 tables where there were migrations from formats of v0.5 And also: - [x] add k2v to default features - [x] silence clippy warning about uppercase things in router

lx added 1 commit 2023-01-03 13:45:22 +00:00

Refactor how things are migrated cdb2a591e9

lx added 1 commit 2023-01-03 13:45:54 +00:00

Update cargo.nix a81200d345

lx added 1 commit 2023-01-03 14:08:46 +00:00

cleanup 426d8784da

lx added 1 commit 2023-01-03 14:27:52 +00:00

Make it explicit when using nonversioned encoding 8d5505514f

lx added 1 commit 2023-01-03 14:29:42 +00:00

move debug_serialize to garage_util::encode a54b67740d

lx added 1 commit 2023-01-03 14:30:30 +00:00

cargo fmt d6d571d512

lx added 1 commit 2023-01-03 14:53:26 +00:00

fix doc and add tests for migrate.rs 33f25d26c7

lx added 1 commit 2023-01-03 15:00:28 +00:00

more idiomatic and shorter c106304b9c

lx added 1 commit 2023-01-03 15:04:14 +00:00

use impossible enum type 1d5bdc17a4

lx changed title from WIP: Refactor how things are migrated to Refactor how things are migrated 2023-01-03 15:28:17 +00:00

lx merged commit 73ed9c7403 into main 2023-01-03 15:28:25 +00:00

lx referenced this pull request from a commit 2023-01-03 15:28:25 +00:00

Merge pull request 'Refactor how things are migrated' (#461) from format-migration into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

action

check-aws

The behaviour should be checked against AWS S3

  

action

discussion-needed

We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  

action

for-external-contributors

Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  

action

for-newcomers

An issue that should be newcomer friendly.

  

action

more-info-needed

More information is needed to investigate this issue

  

action

need-funding

This issue represents lots of work, we need to find money to pay our core team work

  

action

triage-required

It's not very clear what we want to do with this issue yet, more thoughts is required

  

kind

correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

kind

ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

kind

improvement

Feature requests that do not fall in other categories

  

kind

performance

Deceptive performance observed OR idea to improve performances

  

kind

testing

Functional tests, integration tests, Jepsen, etc.

  

kind

usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  

kind

wrong-behavior

Unintended behavior

  

prio

critical

Could impact integrity or availability of production clusters

  

prio

low

For issues that we don't want to spend time on until made absolutely necessary

  

scope

admin-api

Issues concerning the administration API

  

scope

background-healing

Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  

scope

build

Issues with Nix, Drone, Rust Compiler, etc.

  

scope

documentation

  

scope

k8s

Kubernetes related, including Helm Charts

  

scope

layout

Linked to the cluster layout and storage management

  

scope

metadata

Metadata Engine (LMDB, sqlite, etc.)

  

scope

ops

Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  

scope

rpc

Linked to RPC

  

scope

s3-api

Related to the S3 API (especially compatibility issues).

  

scope

security

Cryptography-related, auth-related, authorization-related issues

  

scope

telemetry

OpenTelemetry (traces, metrics, etc.)

No labels

action

check-aws

action

discussion-needed

action

for-external-contributors

action

for-newcomers

action

more-info-needed

action

need-funding

action

triage-required

kind

correctness

kind

ideas

kind

improvement

kind

performance

kind

testing

kind

usability

kind

wrong-behavior

prio

critical

prio

low

scope

admin-api

scope

background-healing

scope

build

scope

documentation

scope

k8s

scope

layout

scope

metadata

scope

ops

scope

rpc

scope

s3-api

scope

security

scope

telemetry

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#461

No description provided.