Deuxfleurs
/
garage
43
37
Fork 55
Code Issues 69 Pull Requests 4 Releases 29 Wiki Activity

Refactor how things are migrated #461

Merged
lx merged 9 commits from format-migration into main 2023-01-03 15:28:25 +00:00
Conversation 0 Commits 9 Files Changed 42 +834 -872
lx commented 2023-01-03 13:45:22 +00:00
Owner
Copy Link
  • New trait for things that have old versions from which to be migrated
    • Use it for tables and for the Persister object
  • Make explicit places where non-versioned encoding is used, don't use rmp_serde directly but a wrapper in garage_util
  • Reorganize code for S3 tables where there were migrations from formats of v0.5

And also:

  • add k2v to default features
  • silence clippy warning about uppercase things in router
- [x] New trait for things that have old versions from which to be migrated - [x] Use it for tables and for the Persister object - [x] Make explicit places where non-versioned encoding is used, don't use rmp_serde directly but a wrapper in garage_util - [x] Reorganize code for S3 tables where there were migrations from formats of v0.5 And also: - [x] add k2v to default features - [x] silence clippy warning about uppercase things in router
lx added 1 commit 2023-01-03 13:45:22 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
cdb2a591e9
Refactor how things are migrated
lx added 1 commit 2023-01-03 13:45:54 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
a81200d345
Update cargo.nix
lx added 1 commit 2023-01-03 14:08:46 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
426d8784da
cleanup
lx added 1 commit 2023-01-03 14:27:52 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
8d5505514f
Make it explicit when using nonversioned encoding
lx added 1 commit 2023-01-03 14:29:42 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
a54b67740d
move debug_serialize to garage_util::encode
lx added 1 commit 2023-01-03 14:30:30 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build was killed Details
d6d571d512
cargo fmt
lx added 1 commit 2023-01-03 14:53:26 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
33f25d26c7
fix doc and add tests for migrate.rs
lx added 1 commit 2023-01-03 15:00:28 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
c106304b9c
more idiomatic and shorter
lx added 1 commit 2023-01-03 15:04:14 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
1d5bdc17a4
use impossible enum type
lx changed title from WIP: Refactor how things are migrated to Refactor how things are migrated 2023-01-03 15:28:17 +00:00
lx merged commit 73ed9c7403 into main 2023-01-03 15:28:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#461
No description provided.
Delete Branch "format-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?