Deuxfleurs/garage
48
56
Fork 73
Code Issues 99 Pull requests 13 Releases 30 Wiki Activity

WIP: opentelemetry-0.18 bump #490

Closed
jpds wants to merge 12 commits from jpds/garage:opentelemetry-0.18 into main
pull from: jpds/garage:opentelemetry-0.18
merge into: Deuxfleurs:main
Conversation 7 Commits 12 Files changed 25 +682 -399
jpds commented 2023-01-27 21:12:06 +00:00
Contributor
Copy link
No description provided.
lx commented 2023-01-30 16:37:32 +00:00
Owner
Copy link

Can you allow me to push the updated cargo.nix?

Can you allow me to push the updated cargo.nix?
jpds commented 2023-01-30 18:12:24 +00:00
Author
Contributor
Copy link

@lx Thanks, done.

@lx Thanks, done.
jpds force-pushed opentelemetry-0.18 from 3c466b75f4 to e825014508 2023-01-30 20:04:42 +00:00 Compare
jpds commented 2023-01-30 20:07:09 +00:00
Author
Contributor
Copy link

@lx Can you please regenerate the Cargo.nix file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a git rebase main so that the history is up to date without the extra merge commit.

@lx Can you please regenerate the `Cargo.nix` file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a `git rebase main` so that the history is up to date without the extra merge commit.
lx added 1 commit 2023-01-30 22:02:20 +00:00
Update Cargo.nix
Some checks failed
continuous-integration/drone/pr Build is failing
Details
9521c8c254
lx commented 2023-01-30 22:04:13 +00:00
Owner
Copy link

Sorry for messing up, hope this time is good.

It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?

Sorry for messing up, hope this time is good. It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?
jpds commented 2023-01-31 12:17:11 +00:00
Author
Contributor
Copy link

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from netapp.

I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the observer.observe() metrics to the new register_callback().

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from `netapp`. I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the `observer.observe()` metrics to the new `register_callback()`.
lx commented 2023-08-28 09:27:54 +00:00
Owner
Copy link

@jpds are you planning on finishing this or should we close this PR?

@jpds are you planning on finishing this or should we close this PR?
lx commented 2023-10-18 10:04:14 +00:00
Owner
Copy link

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again
lx closed this pull request 2023-10-18 10:04:14 +00:00
Some checks are pending
continuous-integration/drone/pr Build is failing
Details
ci/woodpecker/pr/debug
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#490
No description provided.
Delete branch "jpds/garage:opentelemetry-0.18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?