WIP: opentelemetry-0.18 bump #490

Closed
jpds wants to merge 12 commits from jpds/garage:opentelemetry-0.18 into main
Contributor
No description provided.
Owner

Can you allow me to push the updated cargo.nix?

Can you allow me to push the updated cargo.nix?
Author
Contributor

@lx Thanks, done.

@lx Thanks, done.
jpds force-pushed opentelemetry-0.18 from 3c466b75f4 to e825014508 2023-01-30 20:04:42 +00:00 Compare
Author
Contributor

@lx Can you please regenerate the Cargo.nix file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a git rebase main so that the history is up to date without the extra merge commit.

@lx Can you please regenerate the `Cargo.nix` file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a `git rebase main` so that the history is up to date without the extra merge commit.
lx added 1 commit 2023-01-30 22:02:20 +00:00
Update Cargo.nix
Some checks failed
continuous-integration/drone/pr Build is failing
9521c8c254
Owner

Sorry for messing up, hope this time is good.

It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?

Sorry for messing up, hope this time is good. It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?
Author
Contributor

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from netapp.

I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the observer.observe() metrics to the new register_callback().

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from `netapp`. I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the `observer.observe()` metrics to the new `register_callback()`.
Owner

@jpds are you planning on finishing this or should we close this PR?

@jpds are you planning on finishing this or should we close this PR?
Owner

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again
lx closed this pull request 2023-10-18 10:04:14 +00:00
Some checks are pending
continuous-integration/drone/pr Build is failing
ci/woodpecker/pr/debug
Required

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#490
No description provided.