WIP: opentelemetry-0.18 bump #490
No reviewers
Labels
No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#490
Loading…
Reference in a new issue
No description provided.
Delete branch "jpds/garage:opentelemetry-0.18"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Can you allow me to push the updated cargo.nix?
@lx Thanks, done.
3c466b75f4
toe825014508
@lx Can you please regenerate the
Cargo.nix
file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did agit rebase main
so that the history is up to date without the extra merge commit.Sorry for messing up, hope this time is good.
It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?
Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from
netapp
.I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the
observer.observe()
metrics to the newregister_callback()
.@jpds are you planning on finishing this or should we close this PR?
Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again
Pull request closed