Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

WIP: opentelemetry-0.18 bump #490

Closed
jpds wants to merge 12 commits from jpds/garage:opentelemetry-0.18 into main
pull from: jpds/garage:opentelemetry-0.18
merge into: Deuxfleurs:main
Conversation 7 Commits 12 Files Changed 25 +682 -399
jpds commented 2023-01-27 21:12:06 +00:00
Contributor
Copy Link
No description provided.
lx commented 2023-01-30 16:37:32 +00:00
Owner
Copy Link

Can you allow me to push the updated cargo.nix?

Can you allow me to push the updated cargo.nix?
jpds commented 2023-01-30 18:12:24 +00:00
Author
Contributor
Copy Link

@lx Thanks, done.

@lx Thanks, done.
jpds force-pushed opentelemetry-0.18 from 3c466b75f4 to e825014508 2023-01-30 20:04:42 +00:00 Compare
jpds commented 2023-01-30 20:07:09 +00:00
Author
Contributor
Copy Link

@lx Can you please regenerate the Cargo.nix file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a git rebase main so that the history is up to date without the extra merge commit.

@lx Can you please regenerate the `Cargo.nix` file? The one you pushed weirdly referenced the old opentelemetry version so I think it got confused in the merge. I reverted the commit and did a `git rebase main` so that the history is up to date without the extra merge commit.
lx added 1 commit 2023-01-30 22:02:20 +00:00
continuous-integration/drone/pr Build is failing Details
9521c8c254 Update Cargo.nix
lx commented 2023-01-30 22:04:13 +00:00
Owner
Copy Link

Sorry for messing up, hope this time is good.

It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?

Sorry for messing up, hope this time is good. It looks like the upgrade brought in a bunch of new dependencies (axum, axum-core, machit, opentelemetry-{proto,api,sdk}, prettyplease, sync_wrapper). Are there any feature flags we can disable to avoid pulling these in if we don't really need them?
jpds commented 2023-01-31 12:17:11 +00:00
Author
Contributor
Copy Link

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from netapp.

I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the observer.observe() metrics to the new register_callback().

Not a mess-up - I was just trying to understand where the old opentelemetry crate was being pulled in from and now I see that it's coming from `netapp`. I'll take a look at disabling feature flags once I've finished porting this - this is currently blocked on me porting all the `observer.observe()` metrics to the new `register_callback()`.
lx commented 2023-08-28 09:27:54 +00:00
Owner
Copy Link

@jpds are you planning on finishing this or should we close this PR?

@jpds are you planning on finishing this or should we close this PR?
lx commented 2023-10-18 10:04:14 +00:00
Owner
Copy Link

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again

Opentelemetry is now at 0.20, I think we can safely close this and say that the migration will have to be started over again
lx closed this pull request 2023-10-18 10:04:14 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#490
No description provided.
Delete Branch "jpds/garage:opentelemetry-0.18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?