Deuxfleurs/garage
48
56
Fork 73
Code Issues 99 Pull requests 13 Releases 30 Wiki Activity

block/repair.rs: Added a random element of 10 days to SCRUB_INTERVAL #516

Merged
lx merged 2 commits from jpds/garage:scrub-randomize-window into main 2023-03-06 14:11:25 +00:00
Conversation 3 Commits 2 Files changed 2 +40 -11
jpds commented 2023-03-05 10:34:42 +00:00
Contributor
Copy link

When a Garage cluster is initially set up - the nodes would be scheduled to perform a scrub in 30 days in the future.

This then means that potentially all those nodes will be scrubbing togther whilst also handling user traffic/recovery operations. To help balance this scrub load across cluster - this PR changes the interval to 25 days and adds a random element of 10 days after that.

When a Garage cluster is initially set up - the nodes would be scheduled to perform a scrub in 30 days in the future. This then means that potentially all those nodes will be scrubbing togther whilst also handling user traffic/recovery operations. To help balance this scrub load across cluster - this PR changes the interval to 25 days and adds a random element of 10 days after that.
jpds force-pushed scrub-randomize-window from ff049da88d to bd458d3a12 2023-03-05 11:32:44 +00:00 Compare
lx commented 2023-03-06 10:13:42 +00:00
Owner
Copy link

I think if we want this to be robust, the planned time of the next scrub has to be chosen exactly once and persisted to disk, not chosen randomly every time a sleep call is made.

I think if we want this to be robust, the planned time of the next scrub has to be chosen exactly once and persisted to disk, not chosen randomly every time a sleep call is made.
jpds force-pushed scrub-randomize-window from bd458d3a12 to 34ebbacec1 2023-03-06 12:32:10 +00:00 Compare
jpds commented 2023-03-06 12:33:41 +00:00
Author
Contributor
Copy link

@lx I think I've added this in now.

@lx I think I've added this in now.
lx reviewed 2023-03-06 13:25:12 +00:00
lx left a comment
Owner
Copy link

LGTM, just two minor remarks

LGTM, just two minor remarks
src/block/repair.rs Outdated
@ -178,2 +180,4 @@
pub(crate) corruptions_detected: u64,
}
fn randomize_next_run_time() -> u64 {
lx commented 2023-03-06 13:25:00 +00:00
Owner
Copy link

the name of this function should contain the word scrub, maybe randomize_next_scrub_run_time

the name of this function should contain the word `scrub`, maybe `randomize_next_scrub_run_time`
jpds marked this conversation as resolved
src/block/repair.rs Outdated
@ -337,2 +362,4 @@
self.persister
.set_with(|p| p.time_last_complete_scrub = now_msec())?;
self.persister
.set_with(|p| p.time_next_run_scrub = randomize_next_run_time())?;
lx commented 2023-03-06 13:24:23 +00:00
Owner
Copy link

Probably better to concatenate those two calls in one:

self.persister.set_with(|p| 
  p.time_last_complete_scrub = now_msec();
  p.time_next_run_scrub = randomize_next_run_time();
})?

set_with does non-async (possibly blocking) IO to write the persistent data to disk, better do it only once if possible

Probably better to concatenate those two calls in one: ```rust self.persister.set_with(|p| p.time_last_complete_scrub = now_msec(); p.time_next_run_scrub = randomize_next_run_time(); })? ``` `set_with` does non-async (possibly blocking) IO to write the persistent data to disk, better do it only once if possible
jpds marked this conversation as resolved
jpds force-pushed scrub-randomize-window from 34ebbacec1 to 148b66b843 2023-03-06 13:46:35 +00:00 Compare
lx commented 2023-03-06 14:11:21 +00:00
Owner
Copy link

Thanks!

Thanks!
lx merged commit 2dc80abbb1 into main 2023-03-06 14:11:25 +00:00
jpds deleted branch scrub-randomize-window 2023-03-06 14:18:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#516
No description provided.
Delete branch "jpds/garage:scrub-randomize-window"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?