block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. #523
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#523
Loading…
Reference in New Issue
No description provided.
Delete Branch "jpds/garage:migrate-scrubworkerpersisted"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes: #520.
block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub.to WIP: block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub.0c5bfe2784
toe77d540b29
@lx Can you please review if this is what you expect from this migration change?
LGTM, just some minor remarks
@ -165,0 +187,4 @@
pub(crate) corruptions_detected: u64,
}
//pub use v081::ScrubWorkerPersisted;
comment can be removed
@ -165,0 +198,4 @@
ScrubWorkerPersisted {
tranquility: old.tranquility,
time_last_complete_scrub: old.time_last_complete_scrub,
time_next_run_scrub: randomize_next_scrub_run_time(),
Can this be selected by adding the random interval to the old time_last_complete_scrub rather than starting from now? Otherwise the scrub may never happen if the daemon is continuously restarted
Yep, I was adding that in now - but wanted to verify that the migration was on the right track :-)
yes it's fine :)
d3fea59feb
to7b65dd24e2
WIP: block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub.to block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub.Thanks!