Deuxfleurs/garage
41
56
Fork 73
Code Issues 98 Pull requests 14 Releases 30 Wiki Activity

block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. #523

Merged
lx merged 3 commits from jpds/garage:migrate-scrubworkerpersisted into main 2023-03-10 13:25:02 +00:00
Conversation 2 Commits 3 Files changed 2 +49 -14
jpds commented 2023-03-09 15:39:25 +00:00
Contributor
Copy link

Fixes: #520.

Fixes: #520.
jpds changed title from block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. to WIP: block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. 2023-03-09 15:39:35 +00:00
jpds force-pushed migrate-scrubworkerpersisted from 0c5bfe2784 to e77d540b29 2023-03-09 15:41:07 +00:00 Compare
jpds commented 2023-03-09 15:42:10 +00:00
Author
Contributor
Copy link

@lx Can you please review if this is what you expect from this migration change?

@lx Can you please review if this is what you expect from this migration change?
lx reviewed 2023-03-09 16:04:58 +00:00
lx left a comment
Owner
Copy link

LGTM, just some minor remarks

LGTM, just some minor remarks
src/block/repair.rs Outdated
@ -165,0 +187,4 @@
pub(crate) corruptions_detected: u64,
}
//pub use v081::ScrubWorkerPersisted;
lx commented 2023-03-09 16:03:56 +00:00
Owner
Copy link

comment can be removed

comment can be removed
jpds marked this conversation as resolved
src/block/repair.rs Outdated
@ -165,0 +198,4 @@
ScrubWorkerPersisted {
tranquility: old.tranquility,
time_last_complete_scrub: old.time_last_complete_scrub,
time_next_run_scrub: randomize_next_scrub_run_time(),
lx commented 2023-03-09 16:03:47 +00:00
Owner
Copy link

Can this be selected by adding the random interval to the old time_last_complete_scrub rather than starting from now? Otherwise the scrub may never happen if the daemon is continuously restarted

Can this be selected by adding the random interval to the old time_last_complete_scrub rather than starting from now? Otherwise the scrub may never happen if the daemon is continuously restarted
jpds commented 2023-03-09 16:07:40 +00:00
Author
Contributor
Copy link

Yep, I was adding that in now - but wanted to verify that the migration was on the right track :-)

Yep, I was adding that in now - but wanted to verify that the migration was on the right track :-)
lx commented 2023-03-09 16:08:30 +00:00
Owner
Copy link

yes it's fine :)

yes it's fine :)
jpds marked this conversation as resolved
jpds force-pushed migrate-scrubworkerpersisted from d3fea59feb to 7b65dd24e2 2023-03-09 16:38:49 +00:00 Compare
jpds added 1 commit 2023-03-09 17:09:20 +00:00
block/manager.rs: Set defaults for scrub_persister.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d218f475cb
jpds changed title from WIP: block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. to block/repair.rs: Added migration for ScrubWorkerPersisted's time_next_run_scrub. 2023-03-09 17:09:57 +00:00
lx commented 2023-03-10 13:24:58 +00:00
Owner
Copy link

Thanks!

Thanks!
lx merged commit 3325928c13 into main 2023-03-10 13:25:02 +00:00
jpds deleted branch migrate-scrubworkerpersisted 2023-03-10 13:26:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#523
No description provided.
Delete branch "jpds/garage:migrate-scrubworkerpersisted"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?