Deuxfleurs
/
garage
42
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

Increase Garage tests robustness #526

Merged
lx merged 2 commits from tests/increase-robustness into main 2023-03-13 17:26:21 +00:00
Conversation 1 Commits 2 Files Changed 8 +58 -63
quentin commented 2023-03-13 11:24:56 +00:00
Owner
Copy Link

We are noticing tests failing in a non deterministic way, for 2 reasons:

  • We are sending commands to a garage server that is not yet started
  • We are running ~32 tests in parallel and some race conditions are triggered

This PR address these issues as follow:

  • Replace the static "2sec" wait by a "2sec polling during 2min"
  • Generate one key per context

This PR is not ready for review

We are noticing tests failing in a non deterministic way, for 2 reasons: - We are sending commands to a garage server that is not yet started - We are running ~32 tests in parallel and some race conditions are triggered This PR address these issues as follow: - [X] Replace the static "2sec" wait by a "2sec polling during 2min" - [X] Generate one key per context *This PR is not ready for review*
❤️ 1
quentin commented 2023-03-13 13:01:06 +00:00
Author
Owner
Copy Link

Fix #528

Fix #528
quentin changed title from WIP: Increase Garage tests robustness to Increase Garage tests robustness 2023-03-13 14:04:43 +00:00
quentin force-pushed tests/increase-robustness from fa7248c0a1 to 70b5424b99 2023-03-13 14:06:11 +00:00 Compare
quentin requested review from lx 2023-03-13 14:11:40 +00:00
lx approved these changes 2023-03-13 15:50:06 +00:00
lx left a comment
Owner
Copy Link

LGTM, maybe we can get a review by @trinity-1686a or @KokaKiwi as they contributed to the testing code? Otherwise we can merge as is.

LGTM, maybe we can get a review by @trinity-1686a or @KokaKiwi as they contributed to the testing code? Otherwise we can merge as is.
trinity-1686a approved these changes 2023-03-13 16:08:51 +00:00
trinity-1686a left a comment
Owner
Copy Link

lgtm

lgtm
src/garage/tests/common/garage.rs
@ -22,3 +22,3 @@
process: process::Child,
pub path: PathBuf,
pub key: Key,
pub default_key: Key,
trinity-1686a commented 2023-03-13 16:08:41 +00:00
Owner
Copy Link

is this read anywhere?

is this read anywhere?
src/garage/tests/common/garage.rs
@ -170,3 +183,3 @@
}
pub fn new_key(&self, name: &str) -> Key {
pub fn key(&self, maybe_name: Option<&str>) -> Key {
trinity-1686a commented 2023-03-13 16:07:55 +00:00
Owner
Copy Link

I'm not fond of that name, it sounds too much like a getter imo (not blocking)

I'm not fond of that name, it sounds too much like a getter imo (not blocking)
lx merged commit d6ffa57f40 into main 2023-03-13 17:26:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
trinity-1686a
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#526
No description provided.
Delete Branch "tests/increase-robustness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?